Fix android reload reentrant issue #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
alanjhughes
approved these changes
Nov 5, 2024
Kudo
deleted the
@kudo/eng-14048-expo-go-for-android-sometimes-gets-stuck-on-loading-screen
branch
Kudo
added a commit
to expo/expo
that referenced
this pull request
Nov 5, 2024
# Why fix the issue when long-press `r` in cli and makes expo-go stuck in loading view # How - call `destroyReactHost` on `ReactNativeActivity.onDestroy`. we did similar destroy on [bridge expo-go](https://github.com/expo/expo/blob/001ecb0bb73af35571b6f6429d046f552cf0ffcd/apps/expo-go/android/expoview/src/main/java/host/exp/exponent/experience/ReactNativeActivity.kt#L301) as well. - since the multi-activity expo-go will destory the current activity, the `destroyReactHost` should destroy ReactHost instance. - prevent "home" react instance create a packager connection. we should use `ReleaseDevSupportManager` for "home" in production build. - remove unused code in VersionedUtils.kt - also expo/react-native#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
close ENG-14048
How
terminate packager connection right after triggering reload