Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "for each" code usage #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove "for each" code usage #13

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0b3495
Remove unnecessary "each" keyword in for loop
clstopher Jan 9, 2025
1e19471
Remove "for each" usage from the purchase feed code
clstopher Jan 9, 2025
e10447c
Remove "for each" usage from the purchase product feed code
clstopher Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 39 additions & 10 deletions ..._bloomreach_engagement/cartridge/scripts/helpers/BloomreachEngagementGenerateCSVHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ function updateOrderExportDate(jobID,date) {
*/
function writePurchaseFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject) {
var orderCSVAttributes = [];
/** @type {dw.util.Iterator} */
var itemIterator;
for (var i = 0; i < headers.length; i++){
if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.PURCHASESTATUS)){
orderCSVAttributes.push(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.SUCCESS);
Expand All @@ -64,7 +66,10 @@ function writePurchaseFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject) {
}else if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.PURCHASESOURCENAME)){
orderCSVAttributes.push(URLUtils.home().toString());
}else if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.SHIPPINGCOMPANY)){
for each(var lineItem in bloomreachOrderObject.allLineItems){
itemIterator = bloomreachOrderObject.allLineItems.iterator();
while (itemIterator.hasNext()) {
/** @type {dw.order.LineItem} */
var lineItem = itemIterator.next();
if(lineItem.lineItemText.equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.SHIPPING)){
orderCSVAttributes.push(lineItem.ID);
}
Expand All @@ -79,7 +84,10 @@ function writePurchaseFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject) {
orderCSVAttributes.push(!empty(bloomreachOrderObject.allProductLineItems[0].product[SFCCAttr[i].SFCCProductAttribute]) && !empty(bloomreachOrderObject.allProductLineItems[0].product[SFCCAttr[i].SFCCProductAttribute].parent) && !empty(bloomreachOrderObject.allProductLineItems[0].product[SFCCAttr[i].SFCCProductAttribute].parent.parent)? URLUtils.abs('Search-Show','cgid',bloomreachOrderObject.allProductLineItems[0].product[SFCCAttr[i].SFCCProductAttribute].parent.parent.ID).toString() : "");
}else if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.DISCOUNTVALUE)){
var valueExist = false;
for each(var lineItem in bloomreachOrderObject.allLineItems){
itemIterator = bloomreachOrderObject.allLineItems.iterator();
while (itemIterator.hasNext()) {
/** @type {dw.order.LineItem} */
var lineItem = itemIterator.next();
if('appliedDiscount' in lineItem){
orderCSVAttributes.push(lineItem.priceValue);
valueExist = true;
Expand All @@ -91,7 +99,10 @@ function writePurchaseFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject) {
}
}else if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.DISCOUNTPERCENTAGE)){
var valueExist = false;
for each(var lineItem in bloomreachOrderObject.allLineItems){
itemIterator = bloomreachOrderObject.allLineItems.iterator();
while (itemIterator.hasNext()) {
/** @type {dw.order.LineItem} */
var lineItem = itemIterator.next();
if('appliedDiscount' in lineItem){
orderCSVAttributes.push(lineItem.appliedDiscount.percentage);
valueExist = true;
Expand All @@ -104,7 +115,10 @@ function writePurchaseFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject) {
}else if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.PRODUCTLIST)){
var jsonObj = {};
var arrayObj = [];
for each (var productLineItem in bloomreachOrderObject.allProductLineItems){
itemIterator = bloomreachOrderObject.allProductLineItems.iterator();
while (itemIterator.hasNext()) {
/** @type {dw.order.ProductLineItem} */
var productLineItem = itemIterator.next();
var productID = productLineItem.product ? ('masterProduct' in productLineItem.product ? productLineItem.product.masterProduct.ID : productLineItem.product.ID) : '';
jsonObj.productId = productID;
jsonObj.quantity = productLineItem.quantityValue;
Expand All @@ -113,7 +127,10 @@ function writePurchaseFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject) {
orderCSVAttributes.push(arrayObj.toString());
}else if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.PRODUCTIDS)){
var arrayObj = [];
for each (var productLineItem in bloomreachOrderObject.allProductLineItems){
itemIterator = bloomreachOrderObject.allProductLineItems.iterator();
while (itemIterator.hasNext()) {
/** @type {dw.order.ProductLineItem} */
var productLineItem = itemIterator.next();
var productID = productLineItem.product ? ('masterProduct' in productLineItem.product ? productLineItem.product.masterProduct.ID : productLineItem.product.ID) : '';
arrayObj.push(productID);
}
Expand All @@ -134,11 +151,17 @@ function writePurchaseFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject) {
function writePurchaseProductFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject) {
var a = BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.CATEGORYLEVEL1;
var orderCSVAttributesRows = [];
for each (var productLineItem in bloomreachOrderObject.allProductLineItems){
/** @type {dw.util.Iterator} */
var itemIterator = bloomreachOrderObject.allProductLineItems.iterator();
while (itemIterator.hasNext()) {
/** @type {dw.order.ProductLineItem} */
var productLineItem = itemIterator.next();
var orderCSVAttributes = [];
var isOptionPLItem = productLineItem.isOptionProductLineItem();
/** @type {dw.util.Iterator} */
var subItemIterator;

for each (var i = 0; i < headers.length; i++){
for (var i = 0; i < headers.length; i++){
if (isOptionPLItem && headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.TITLE)) {
var optionItemText = productLineItem.lineItemText;
orderCSVAttributes.push(optionItemText);
Expand All @@ -147,7 +170,10 @@ function writePurchaseProductFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject)
}else if (headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.TOTALQUANTITY)){
orderCSVAttributes.push(bloomreachOrderObject.allProductQuantities.values().toArray().join(','));
}else if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.SHIPPINGCOMPANY)){
for each(var lineItem in bloomreachOrderObject.allLineItems){
subItemIterator = bloomreachOrderObject.allLineItems.iterator();
while(subItemIterator.hasNext()){
/** @type {dw.order.LineItem} */
var lineItem = subItemIterator.next();
if(lineItem.lineItemText.equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.SHIPPING)){
orderCSVAttributes.push(lineItem.ID);
}
Expand Down Expand Up @@ -181,8 +207,11 @@ function writePurchaseProductFeedRow(csw,headers,SFCCAttr,bloomreachOrderObject)
orderCSVAttributes.push(JSON.stringify(jsonObj));
}else if(headers[i].equalsIgnoreCase(BloomreachEngagementConstants.PRODUCT_ATTRIBUTES.PRODUCTIDS)){
var arrayObj = [];
for each (var productLineItem in bloomreachOrderObject.allProductLineItems){
var productID = productLineItem.product ? ('masterProduct' in productLineItem.product ? productLineItem.product.masterProduct.ID : productLineItem.product.ID) : '';
subItemIterator = bloomreachOrderObject.allProductLineItems.iterator();
while(subItemIterator.hasNext()){
/** @type {dw.order.ProductLineItem} */
var subProductLineItem = subItemIterator.next();
var productID = subProductLineItem.product ? ('masterProduct' in subProductLineItem.product ? subProductLineItem.product.masterProduct.ID : subProductLineItem.product.ID) : '';
arrayObj.push(productID);
}
orderCSVAttributes.push(arrayObj.toString());
Expand Down