Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code style: semicolons or no? #72

Open
coolaj86 opened this issue Aug 11, 2018 · 6 comments
Open

code style: semicolons or no? #72

coolaj86 opened this issue Aug 11, 2018 · 6 comments
Assignees

Comments

@coolaj86
Copy link

Some lines have them. Some lines don't. Some lines have extra.

I don't care which way you want it (though for myself I prefer to follow the language spec and have them), but I assume that it should be one or the other and not 50/50.

I'd be happy to PR with or without if you let me know which you prefer.

@dougwilson
Copy link
Contributor

This project was just a semicolon style, but all Express.js project are changing to StandardJS style. Only lines changes since that decision have been changed to StandardJS style otherwise all PSs will no longer merge if you suddenly removed all semicolons.

If you have a method to change it to StandardJS but not leave all the open PRs in an un-mergable state, please let me know!

@dougwilson
Copy link
Contributor

I started going through the PRs and it looks like several have been stale and I closed them. Give me a couple days to look through the PRs and perhaps they'll all be closed, which would leave open the ability to make a PR to change everything to StandardJS if you want to 👍 (ensure it validates the style in CI -- just copy exactly how all the other Express.js projects enforce their StandardJS styling).

@coolaj86
Copy link
Author

Deal.

@dougwilson
Copy link
Contributor

I was able to get through just about all of them this weekend. At least one that was not closed out got s new pr made that will merge.

With the work week starting I'll see how much I can fit in, but may need until next weekend to get them all either merged or closed out.

@coolaj86
Copy link
Author

Awesome!

@coolaj86
Copy link
Author

bump

If there's anything you can farm out to me - merging, testing, etc - I'd be happy to do it. I strongly believe that this module has potential to go from good to great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants