Skip to content

Commit 2e22086

Browse files
authored
Revert "feat: conditionally set headers (if not already set) in redirect response (#190)" (#200)
This reverts commit b51ab84.
1 parent 6a1aa93 commit 2e22086

File tree

2 files changed

+6
-27
lines changed

2 files changed

+6
-27
lines changed

index.js

+5-16
Original file line numberDiff line numberDiff line change
@@ -198,22 +198,11 @@ function createRedirectDirectoryListener () {
198198

199199
// send redirect response
200200
res.statusCode = 301
201-
setHeaderIfNotSet(res, 'Content-Type', 'text/html; charset=UTF-8')
202-
setHeaderIfNotSet(res, 'Content-Length', Buffer.byteLength(doc))
203-
setHeaderIfNotSet(res, 'Content-Security-Policy', "default-src 'none'")
204-
setHeaderIfNotSet(res, 'X-Content-Type-Options', 'nosniff')
205-
setHeaderIfNotSet(res, 'Location', loc)
201+
res.setHeader('Content-Type', 'text/html; charset=UTF-8')
202+
res.setHeader('Content-Length', Buffer.byteLength(doc))
203+
res.setHeader('Content-Security-Policy', "default-src 'none'")
204+
res.setHeader('X-Content-Type-Options', 'nosniff')
205+
res.setHeader('Location', loc)
206206
res.end(doc)
207207
}
208208
}
209-
210-
/**
211-
* Set default value for the header only if it is not already set in the response
212-
* @private
213-
*/
214-
215-
function setHeaderIfNotSet (res, name, value) {
216-
if (!res.hasHeader(name)) {
217-
res.setHeader(name, value)
218-
}
219-
}

test/test.js

+1-11
Original file line numberDiff line numberDiff line change
@@ -468,9 +468,6 @@ describe('serveStatic()', function () {
468468
before(function () {
469469
server = createServer(fixtures, null, function (req, res) {
470470
req.url = req.url.replace(/\/snow(\/|$)/, '/snow \u2603$1')
471-
if (req.url.match(/\/pets/)) {
472-
res.setHeader('Content-Security-Policy', "default-src 'self'")
473-
}
474471
})
475472
})
476473

@@ -510,20 +507,13 @@ describe('serveStatic()', function () {
510507
.expect(301, />Redirecting to \/snow%20%E2%98%83\/</, done)
511508
})
512509

513-
it('should respond with default Content-Security-Policy when header is not set', function (done) {
510+
it('should respond with default Content-Security-Policy', function (done) {
514511
request(server)
515512
.get('/users')
516513
.expect('Content-Security-Policy', "default-src 'none'")
517514
.expect(301, done)
518515
})
519516

520-
it('should respond with custom Content-Security-Policy when header is set', function (done) {
521-
request(server)
522-
.get('/pets')
523-
.expect('Content-Security-Policy', "default-src 'self'")
524-
.expect(301, done)
525-
})
526-
527517
it('should not redirect incorrectly', function (done) {
528518
request(server)
529519
.get('/')

0 commit comments

Comments
 (0)