[DRAFT - feedback needed] Sync crate and R package versions #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @eitsupi I would like your eyes on this! I opted for |
|
|
Sure, thats fine. More importantly, though, is the user experience. Do you prefer masking usethis? |
I would also prefer to update only Cargo.toml without wrapping the usethis function as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #304 and is related to #228.
This draft creates two functions
use_version()andsync_version().sync_version()will set the version of the Rust crate insrcto match that in theDESCRIPTIONfile.use_version()wrapsusethis::use_version()and 1. callsusethis::use_version()to increment the package version and 2. syncs the version withsync_version()I personally think masking functions from usethis is a little questionable. I like the workflow of:
Alternatively, we could change the name of
use_version()toincrement_version()to avoid namespace conflicts.