Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal utilities to find rust crate and cargo manifest #399

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

kbvernon
Copy link
Contributor

@kbvernon kbvernon commented Nov 20, 2024

This PR adds internal utility functions that find R package root, build path from there to crate directory or Cargo.toml, and check that directory or file exists. Both return paths. These can be used to consolidate code and provide stronger checks.

Note: this is to simplify efforts to refactor functions to execute Cargo subcommands using processx::run() in PR #397.

Copy link
Contributor

@JosiahParry JosiahParry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! we need to just ensure that the documentation doesn't actually get rendered. That will lead to a rejected package in CRAN

R/find_extendr.R Show resolved Hide resolved
R/find_extendr.R Show resolved Hide resolved
kbvernon and others added 2 commits November 19, 2024 18:21
Co-authored-by: Josiah Parry <[email protected]>
Co-authored-by: Josiah Parry <[email protected]>
@JosiahParry JosiahParry enabled auto-merge (squash) November 20, 2024 01:37
@JosiahParry JosiahParry merged commit d8689d9 into extendr:main Nov 20, 2024
19 checks passed
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (4aefce1) to head (2de41fc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
R/find_extendr.R 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

@kbvernon kbvernon deleted the find_extendr branch November 21, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants