Propagate the error causing rextendr::document()
to fail
#409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a nuisance for many, many years now already.
Invoking
rextendr::document()
invokes{callr}
'sr
function, which spawns a separate R process, meant to load the wrapper-generating functions that are part of the rust-powered r-package, and write that to disk. Unfortunately, if there are any errors attributed with this call, then we do not see the error. The error could be missing libraries inMakevars
(there are related issues), or anything similar, then you don't get the error message.With this slight change, the error message is propagated.
Example
Current behaviour:
New behaviour:
And yes I was refactoring the way wrapper-generating works in
extendr-macros
+extendr-api
.