Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support extism_current_plugin_host_context #19

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: support extism_current_plugin_host_context #19

wants to merge 2 commits into from

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented May 22, 2024

No description provided.

@zshipko zshipko marked this pull request as draft November 14, 2024 23:57
G4Vi
G4Vi approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@G4Vi G4Vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Before, I was waiting for this to be undrafted before I reviewed, but it looks ready to me, I'm sure the mac CI failure is unrelated.

@G4Vi
Copy link
Contributor

G4Vi commented Dec 13, 2024

The crash does not appear to happen locally on Mac. However, I noticed the same ld: warning: object file (/usr/local/lib/libextism.a[653](690f776bf7b37aeb-zstd_decompress.o)) was built for newer 'macOS' version (14.5) than being linked (14.0) version mismatch messages so I just applied a fix to use the same version for both building libextism and the cpp-sdk. It seems like this needs to be troubleshooted on ci, we can start by collecting the logs for the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G4Vi G4Vi G4Vi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zshipko @G4Vi