Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider making resulting modules reactor modules #72

Open
zshipko opened this issue May 8, 2024 · 2 comments
Open

consider making resulting modules reactor modules #72

zshipko opened this issue May 8, 2024 · 2 comments

Comments

@zshipko
Copy link
Contributor

zshipko commented May 8, 2024

Running a js-pdk plugin with extism-wamr gives a warning:

[15:03:41:772 - 7F54D39B9740]: warning: a module with WASI apis should be either a command or a reactor

We may want to add an _initialize export to fulfill this expectation

@bhelx
Copy link
Contributor

bhelx commented Jun 14, 2024

Can we just add this as an export to the core crate? What do we need to do to accomplish this?

@zshipko
Copy link
Contributor Author

zshipko commented Jun 14, 2024

Yeah we could probably just add an empty _initialize function. The main blocker is just trying to understand how important this change really is. WAMR is the only runtime that has an issue with it, and even there it's just a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants