Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out correct rustc flags for rust >= 1.82.0 #23

Open
zshipko opened this issue Nov 8, 2024 · 2 comments
Open

Figure out correct rustc flags for rust >= 1.82.0 #23

zshipko opened this issue Nov 8, 2024 · 2 comments

Comments

@zshipko
Copy link
Contributor

zshipko commented Nov 8, 2024

It seems like after 1.81 rust requires some (nightly only?) flags to build the wasm code correctly. See https://blog.rust-lang.org/2024/09/24/webassembly-targets-change-in-default-target-features.html

@zshipko
Copy link
Contributor Author

zshipko commented Nov 11, 2024

The only solution that works (which is from that link) requires switching to nightly. We need to figure out what the trade-offs are between switching to nightly or only supporting <= 1.81

@fliepeltje
Copy link
Contributor

Regardless of how you end up solving this, it might be good to include a rust-toolchain.toml and amend it as you go. I've made a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants