Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add section on installing rustup and wasm32 target #49

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

apisorbust
Copy link
Contributor

When working through the example as a first time rust dev.. I did not have rustup or the wasm32-unknown-unknown target installed. So I had problems building the example. This addition is to help those that may be in a similar boat ensuring they have the necessary target so the build will work.

…n-unknown target if not installed as the example wont build without it
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nilslice
Copy link
Member

nilslice commented Feb 9, 2024

@apisorbust - just added a couple suggested changes, but otherwise great addition! If you like, you can accept these changes in the UI here, or make them on your branch and commit & push.

apisorbust and others added 4 commits February 8, 2024 20:23
Co-authored-by: Steve Manuel <[email protected]>
Co-authored-by: Steve Manuel <[email protected]>
Co-authored-by: Steve Manuel <[email protected]>
Co-authored-by: Steve Manuel <[email protected]>
@apisorbust
Copy link
Contributor Author

Accepted your changes. Very nice!

README.md Outdated Show resolved Hide resolved
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just going to let CI run and I'll merge on ✅

@nilslice
Copy link
Member

nilslice commented Feb 9, 2024

Thank you, @apisorbust!


```bash
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
```
Copy link
Contributor

@bhelx bhelx Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement of this is a little strange because just a moment earlier, the user was running cargo, etc. So if they don't have rust installed they should be failing there right? Should we maybe move this up?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I'd support that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I thought about that but assumed they probably had rust/cargo installed but maybe not rustup. Total noob so wasn't sure if rustup was part of the typical rust install.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually.. should the comment and ### Rustup.. part be up at the top too? Thus this whole bit is at the top? Otherwise just the curl command may look a little odd.

Comment on lines +35 to +42

Once `rustup` is installed, add the `wasm32-unknown-unknown` target:

```bash
rustup target add wasm32-unknown-unknown
```


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here, didn't realize this got left behind...

Actually.. should the comment and ### Rustup.. part be up at the top too? Thus this whole bit is at the top? Otherwise just the curl command may look a little odd.

Do you mean to include this code attached here to the curl command to be moved up?

@nilslice nilslice changed the title added a section on installing rustup and installing the wasm32-unknow… docs: add section on installing rustup and wasm32 target May 20, 2024
@cqian12
Copy link

cqian12 commented Jun 17, 2024

@nilslice does anything else need to be done on this? wasn't sure if the question above is still outstanding

Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just merge this as-is and we can update later if needed.

@nilslice nilslice merged commit 7bd2b8e into extism:main Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants