feat: make loglevel pub and only alloc when needed #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilslice
commented
Nov 4, 2024
Comment on lines
+235
to
+247
| fn loggingEnabled(level: LogLevel) bool { | ||
| const currentLevelInt = extism.get_log_level(); | ||
| if (currentLevelInt == std.math.maxInt(i32)) { | ||
| return false; | ||
| } | ||
|
|
||
| const levelInt = @intFromEnum(level); | ||
| if (levelInt >= currentLevelInt) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
@zshipko, just a second set of eyes on the logic here would be helpful :)
nilslice
commented
Nov 4, 2024
| pub fn setErrorFmt(self: Plugin, comptime fmt: []const u8, args: anytype) !void { | ||
| const data = try std.fmt.allocPrint(self.allocator, fmt, args); | ||
| self.setError(data); | ||
| } |
There was a problem hiding this comment.
quality of life improvement (relates to #32)
nilslice
commented
Nov 4, 2024
| if (loggingEnabled(level)) { | ||
| const data = try std.fmt.allocPrint(self.allocator, fmt, args); | ||
| self.log(level, data); | ||
| } |
There was a problem hiding this comment.
quality of life improvement (relates to #32)
zshipko
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Fixes #32
& relates to dylibso/xtp-zig-bindgen#10