Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty message on plasma #51

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

Acetylsalicylsaeure
Copy link
Contributor

sending to /dev/pts/0 leads to a erronious notification on KDE plasma. not breaking, but annoying.

adds a check to not do that when the DE is "plasma", addition of other DEs with the problem welcome

@eylles
Copy link
Owner

eylles commented Jun 4, 2024

thanks, i've never experienced such an error message on xfce, mate nor awesomewm.

question, does it only happen with /dev/pts/0 or with all /dev/pts/ devices?

@eylles eylles added this to the 3.6.0 milestone Jun 4, 2024
@Acetylsalicylsaeure
Copy link
Contributor Author

added the check just for /dev/pts/0, as referenced here, and that fixed the issue for me. furthermore, looking at /var/log/messages, i find this error message

plasmashell[2757]: org.kde.plasma.notificationmanager: Notification to send to backend contains invalid XML: "Unexpected ''." line 1 col 7

i can only assume that pts/0 is reserved by the root shell for special purposes?

happend on fedora 37, plasma 5 and after updating on fedora 40, plasma 6

@eylles
Copy link
Owner

eylles commented Jun 5, 2024

okay, merging.

@eylles eylles merged commit b9ce25b into eylles:master Jun 5, 2024
@eylles eylles mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants