IBX-1247: Promoted scale & precision as top-level field options

For more details see https://issues.ibexa.co/browse/IBX-1247 and #23
ezsystems · Oct 13, 2021 · 64f7092 · 64f7092
1 parent d0c7dab
commit 64f7092
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/src/lib/Importer/SchemaImporter.php b/src/lib/Importer/SchemaImporter.php
@@ -128,6 +128,14 @@ private function addSchemaTableColumns(Table $table, array $columnList): void
                 $columnConfiguration['options']['length'] = $columnConfiguration['length'];
             }
 
+            if (isset($columnConfiguration['scale'])) {
+                $columnConfiguration['options']['scale'] = $columnConfiguration['scale'];
+            }
+
+            if (isset($columnConfiguration['precision'])) {
+                $columnConfiguration['options']['precision'] = $columnConfiguration['precision'];
+            }
+
             $column = $table->addColumn(
                 $columnName,
                 $columnConfiguration['type'],

diff --git a/tests/lib/Importer/SchemaImporterTest.php b/tests/lib/Importer/SchemaImporterTest.php
@@ -170,6 +170,22 @@ public function providerForTestImportFromFile(): array
                     ]
                 ),
             ],
+            7 => [
+                '07-numeric-options.yaml',
+                new Schema(
+                    [
+                        new Table(
+                            'my_table',
+                            [
+                                (new Column(
+                                    'data',
+                                    Type::getType('decimal'))
+                                )->setPrecision(19)->setScale(4),
+                            ]
+                        ),
+                    ]
+                ),
+            ],
         ];
 
         return $data;

diff --git a/tests/lib/Importer/_fixtures/07-numeric-options.yaml b/tests/lib/Importer/_fixtures/07-numeric-options.yaml
@@ -0,0 +1,4 @@
+tables:
+    my_table:
+        fields:
+            data: { type: decimal, precision: 19, scale: 4 }