From 7344524fbe60fa1c9e7d9b7baecb23d00b772866 Mon Sep 17 00:00:00 2001
From: konradoboza <34310128+konradoboza@users.noreply.github.com>
Date: Wed, 11 Apr 2018 23:53:44 +0200
Subject: [PATCH] Fix EZP-28967: RichText FieldType removes line breaks inside
 table cells (#2301)

---
 .../stylesheets/docbook/xhtml5/edit/core.xsl         | 12 ++++++++++++
 .../stylesheets/docbook/xhtml5/output/core.xsl       | 12 ++++++++++++
 .../Resources/stylesheets/xhtml5/edit/docbook.xsl    |  8 ++++++--
 .../Xslt/_fixtures/docbook/018-htmlTable.xml         |  6 ++++--
 .../Xslt/_fixtures/ezxml/018-htmlTable.lossy.xml     |  6 ++++--
 .../Xslt/_fixtures/xhtml5/edit/018-htmlTable.xml     |  4 ++--
 .../Xslt/_fixtures/xhtml5/output/018-htmlTable.xml   |  4 ++--
 7 files changed, 42 insertions(+), 10 deletions(-)

diff --git a/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/docbook/xhtml5/edit/core.xsl b/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/docbook/xhtml5/edit/core.xsl
index 00533a7c142..24981f3495c 100644
--- a/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/docbook/xhtml5/edit/core.xsl
+++ b/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/docbook/xhtml5/edit/core.xsl
@@ -358,6 +358,12 @@
     </xsl:element>
   </xsl:template>
 
+  <xsl:template match="docbook:th/text()">
+    <xsl:call-template name="breakLine">
+      <xsl:with-param name="text" select="."/>
+    </xsl:call-template>
+  </xsl:template>
+
   <xsl:template match="docbook:th">
     <xsl:element name="th" namespace="{$outputNamespace}">
       <xsl:if test="@class">
@@ -421,6 +427,12 @@
     </xsl:element>
   </xsl:template>
 
+  <xsl:template match="docbook:td/text()">
+    <xsl:call-template name="breakLine">
+      <xsl:with-param name="text" select="."/>
+    </xsl:call-template>
+  </xsl:template>
+
   <xsl:template match="docbook:td">
     <xsl:element name="td" namespace="{$outputNamespace}">
       <xsl:if test="@class">
diff --git a/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/docbook/xhtml5/output/core.xsl b/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/docbook/xhtml5/output/core.xsl
index 4416f2f2f6d..bffecfeac64 100644
--- a/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/docbook/xhtml5/output/core.xsl
+++ b/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/docbook/xhtml5/output/core.xsl
@@ -365,6 +365,12 @@
     </xsl:element>
   </xsl:template>
 
+  <xsl:template match="docbook:th/text()">
+    <xsl:call-template name="breakLine">
+      <xsl:with-param name="text" select="."/>
+    </xsl:call-template>
+  </xsl:template>
+
   <xsl:template match="docbook:th">
     <xsl:element name="th" namespace="{$outputNamespace}">
       <xsl:if test="@class">
@@ -428,6 +434,12 @@
     </xsl:element>
   </xsl:template>
 
+  <xsl:template match="docbook:td/text()">
+    <xsl:call-template name="breakLine">
+      <xsl:with-param name="text" select="."/>
+    </xsl:call-template>
+  </xsl:template>
+
   <xsl:template match="docbook:td">
     <xsl:element name="td" namespace="{$outputNamespace}">
       <xsl:if test="@class">
diff --git a/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/xhtml5/edit/docbook.xsl b/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/xhtml5/edit/docbook.xsl
index 258e9d1161b..c06992c6450 100644
--- a/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/xhtml5/edit/docbook.xsl
+++ b/eZ/Publish/Core/FieldType/RichText/Resources/stylesheets/xhtml5/edit/docbook.xsl
@@ -437,7 +437,9 @@
           <xsl:value-of select="@scope"/>
         </xsl:attribute>
       </xsl:if>
-      <xsl:apply-templates/>
+      <xsl:call-template name="breakline">
+       <xsl:with-param name="node" select="node()"/>
+      </xsl:call-template>
     </th>
   </xsl:template>
 
@@ -491,7 +493,9 @@
           <xsl:value-of select="@rowspan"/>
         </xsl:attribute>
       </xsl:if>
-      <xsl:apply-templates/>
+      <xsl:call-template name="breakline">
+        <xsl:with-param name="node" select="node()"/>
+      </xsl:call-template>
     </td>
   </xsl:template>
 
diff --git a/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/docbook/018-htmlTable.xml b/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/docbook/018-htmlTable.xml
index 512f91e8840..91facf83628 100644
--- a/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/docbook/018-htmlTable.xml
+++ b/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/docbook/018-htmlTable.xml
@@ -8,11 +8,13 @@
     <caption>Table caption.</caption>
     <tbody>
       <tr class="rowClass1">
-        <th class="headingClass1" ezxhtml:width="102" valign="top" colspan="1" rowspan="5" abbr="XSLT" scope="col">11</th>
+        <th class="headingClass1" ezxhtml:width="102" valign="top" colspan="1" rowspan="5" abbr="XSLT" scope="col">11
+with some line break</th>
         <th class="headingClass2" ezxhtml:width="37%" valign="middle" colspan="2" rowspan="6" abbr="XSD" scope="row">12</th>
       </tr>
       <tr class="rowClass2">
-        <td class="cellClass1" ezxhtml:width="74%" valign="bottom" colspan="3" rowspan="7">21</td>
+        <td class="cellClass1" ezxhtml:width="74%" valign="bottom" colspan="3" rowspan="7">21
+with some line break</td>
         <td class="cellClass2" ezxhtml:width="38" valign="baseline" colspan="4" rowspan="8">22</td>
       </tr>
     </tbody>
diff --git a/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/018-htmlTable.lossy.xml b/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/018-htmlTable.lossy.xml
index e47ee0e6022..504a9537ebc 100644
--- a/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/018-htmlTable.lossy.xml
+++ b/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/018-htmlTable.lossy.xml
@@ -19,7 +19,8 @@ the same as a original.
     <table class="tableClass" width="24%" border="0" custom:summary="tableTitle" custom:caption="Table caption.">
       <tr class="rowClass1">
         <th class="headingClass1" xhtml:width="102" custom:valign="top" xhtml:colspan="1" xhtml:rowspan="5" custom:abbr="XSLT" custom:scope="col">
-          <paragraph>11</paragraph>
+          <paragraph>11
+with some line break</paragraph>
         </th>
         <th class="headingClass2" xhtml:width="37%" custom:valign="middle" xhtml:colspan="2" xhtml:rowspan="6" custom:abbr="XSD" custom:scope="row">
           <paragraph>12</paragraph>
@@ -27,7 +28,8 @@ the same as a original.
       </tr>
       <tr class="rowClass2">
         <td class="cellClass1" xhtml:width="74%" custom:valign="bottom" xhtml:colspan="3" xhtml:rowspan="7">
-          <paragraph>21</paragraph>
+          <paragraph>21
+with some line break</paragraph>
         </td>
         <td class="cellClass2" xhtml:width="38" custom:valign="baseline" xhtml:colspan="4" xhtml:rowspan="8">
           <paragraph>22</paragraph>
diff --git a/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/xhtml5/edit/018-htmlTable.xml b/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/xhtml5/edit/018-htmlTable.xml
index 96155f47b06..27c134686e3 100644
--- a/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/xhtml5/edit/018-htmlTable.xml
+++ b/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/xhtml5/edit/018-htmlTable.xml
@@ -4,11 +4,11 @@
     <caption>Table caption.</caption>
     <tbody>
       <tr class="rowClass1">
-        <th class="headingClass1" colspan="1" rowspan="5" abbr="XSLT" scope="col" style="width:102px;vertical-align:top;">11</th>
+        <th class="headingClass1" colspan="1" rowspan="5" abbr="XSLT" scope="col" style="width:102px;vertical-align:top;">11<br/>with some line break</th>
         <th class="headingClass2" colspan="2" rowspan="6" abbr="XSD" scope="row" style="width:37%;vertical-align:middle;">12</th>
       </tr>
       <tr class="rowClass2">
-        <td class="cellClass1" colspan="3" rowspan="7" style="width:74%;vertical-align:bottom;">21</td>
+        <td class="cellClass1" colspan="3" rowspan="7" style="width:74%;vertical-align:bottom;">21<br/>with some line break</td>
         <td class="cellClass2" colspan="4" rowspan="8" style="width:38px;vertical-align:baseline;">22</td>
       </tr>
     </tbody>
diff --git a/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/xhtml5/output/018-htmlTable.xml b/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/xhtml5/output/018-htmlTable.xml
index 32165f541e6..ec6f249d3fc 100644
--- a/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/xhtml5/output/018-htmlTable.xml
+++ b/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/xhtml5/output/018-htmlTable.xml
@@ -4,11 +4,11 @@
     <caption>Table caption.</caption>
     <tbody>
       <tr class="rowClass1">
-        <th class="headingClass1" colspan="1" rowspan="5" abbr="XSLT" scope="col" style="width:102px;vertical-align:top;">11</th>
+        <th class="headingClass1" colspan="1" rowspan="5" abbr="XSLT" scope="col" style="width:102px;vertical-align:top;">11<br/>with some line break</th>
         <th class="headingClass2" colspan="2" rowspan="6" abbr="XSD" scope="row" style="width:37%;vertical-align:middle;">12</th>
       </tr>
       <tr class="rowClass2">
-        <td class="cellClass1" colspan="3" rowspan="7" style="width:74%;vertical-align:bottom;">21</td>
+        <td class="cellClass1" colspan="3" rowspan="7" style="width:74%;vertical-align:bottom;">21<br/>with some line break</td>
         <td class="cellClass2" colspan="4" rowspan="8" style="width:38px;vertical-align:baseline;">22</td>
       </tr>
     </tbody>