Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom HTTP headers to be set for only the front page #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edorfaus
Copy link

Enables custom HTTP headers to be set for only / without setting them for its children.

This makes Header[/]=value;0;0 behave similarly to Header[/foo]=value;0;0 in that only the specified path will have the header set, and not any of its children. Previously, Header[/]=value;0;0 would also set the header for the immediate children of / (including /foo, but not /foo/bar).

…for its children.

Without this, specifying e.g. Pragma[/]=cache;0;0 would set Pragma for both / and e.g. /news.
@andrerom
Copy link
Contributor

Hi, thanks for the patch!

Hopefully someone will have time to review and test it soon. In the mean time I can't seem to find your CLA, have you (or your company) sent one?
If so could you update your github profile to contain something we can identify you by? :)
If not, take a look here for how to send one: http://share.ez.no/community-project/contributor-licensing-agreement-cla

@edorfaus
Copy link
Author

Hi, you're welcome!

I haven't personally sent a CLA (afair), but my company (NXC AS) might have - I can check tomorrow. (I probably shouldn't have used my personal github account to send this, but it was just too convenient... Anyway, added my real name for identification.)

However, according to that page I don't think I should need to for this particular fix anyway - it says that you don't need it for small patches and bugfixes (as they're not necessarily copyrightable anyway), and if this (5 lines, could have been 2 if not for code style) isn't small, I don't know what is...

@edorfaus
Copy link
Author

Yep, according to my boss we sent in a CLA years ago. We've been changing our name a bit though; we're called NXC now, but probably went by Nexus Consulting back then (or maybe Nexus Knowledge Solutions).

@andrerom
Copy link
Contributor

Ok, found it when you updated your profile ;)

peterkeung pushed a commit to peterkeung/ezpublish that referenced this pull request Jul 10, 2019
* FIX Bug : call count function on non countable variable

* Removing some un-used variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants