Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added OpenAPIConfig #10

Closed
wants to merge 2 commits into from
Closed

feat: Added OpenAPIConfig #10

wants to merge 2 commits into from

Conversation

koreanMike513
Copy link
Collaborator

  • Open API Spec 에 대해서 조사를 진행 (여기)
  • 그 후 프로젝트에 Open API Spec 자동화를 Spring Doc 을 사용하여 구현

Spring Doc 과 Spring Fox를 고려해 보았고

  • Spring Fox가 Spring Boot 3.xx 버전 부터는 호환이 Spring Doc에 비해서 좋지 않다는 의견 여기 및
  • Spring Fox가 유지보수가 잘 이루어지고 있다는 것을 고려하여 여기

Spring Doc으로 Open API Spec 자동화를 구현하기로 결정하였습니다.

결과

스크린샷 2024-12-21 오후 2 02 23

@koreanMike513
feat: Added basic domains
d3363dd 
- added order, food, payment, store entities
- added JpaConfig with time related auditing features
- updated application.properties
- added test minusQuantity() method in Food entity

closes #7
@koreanMike513
feat: Added OpenAPIConfig
4a60999 
- added springdoc webmvc ui package
- added OpenApiConfig file to config

closes #9
@koreanMike513 koreanMike513 added the enhancement New feature or request label Dec 21, 2024
@koreanMike513 koreanMike513 self-assigned this Dec 21, 2024
f-lab-troy
f-lab-troy approved these changes Dec 23, 2024
View reviewed changes
Copy link

@f-lab-troy f-lab-troy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마찬가지로 계속 중복된 파일이 코드리뷰에 포함되는 것 같습니다. 새 브랜치로 작업 부탁드립니다.

@koreanMike513 koreanMike513 deleted the feature/add-swagger-openapi branch December 23, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-troy f-lab-troy f-lab-troy approved these changes

Assignees

@koreanMike513 koreanMike513

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koreanMike513 @f-lab-troy