Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature annotation #7

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Feature annotation #7

merged 4 commits into from
Dec 10, 2024

Conversation

CUCU7103
Copy link
Collaborator

๐Ÿ“Œ PR ์ œ๋ชฉ

  • ์–ด๋…ธํ…Œ์ด์…˜์— ์ฃผ์„ ์ถ”๊ฐ€ ๋ฐ ๊ธฐํƒ€ ์ˆ˜์ •

๐Ÿš€ ๋ณ€๊ฒฝ ์‚ฌํ•ญ (Changes)

  • ์‚ฌ์šฉํ•œ ์–ด๋…ธํ…Œ์ด์…˜์— ๋Œ€ํ•ด์„œ ์ฃผ์„์œผ๋กœ ์„ค๋ช…์ถ”๊ฐ€
  • p6spy ๋””๋ ‰ํ† ๋ฆฌ ๋ณ€๊ฒฝ
  • ๋ถˆํ•„์š”ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ํด๋ž˜์Šค ์‚ญ์ œ

๐Ÿ’ฅ ๊ด€๋ จ ์ด์Šˆ (Related Issues)

๐Ÿ’ฌ ๋ฆฌ๋ทฐ ์š”๊ตฌ์‚ฌํ•ญ

๐Ÿšด ์ฒดํฌ๋ฆฌ์ŠคํŠธ (Checklist)

  • else ํ‚ค์›Œ๋“œ ์‚ฌ์šฉํ•˜์ง€ ์•Š๊ธฐ
  • getter/setter/property๋ฅผ ์“ฐ์ง€ ์•Š๊ธฐ
  • ํ•œ ์ค„์— ์ ์„ ํ•˜๋‚˜๋งŒ ์ฐ๊ธฐ (๋””๋ฏธํ„ฐ์˜ ๋ฒ•์น™)
  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ์—ฌ๋ถ€
  • ๋„ค์ด๋ฒ„ ์ฝ”๋“œ ์ปจ๋ฒค์…˜ ์ค€์ˆ˜์—ฌ๋ถ€

@CU7103
Chore: ์–ด๋…ธํ…Œ์ด์…˜ ์„ค๋ช…
53bae7a 
์–ด๋…ธํ…Œ์ด์…˜์— ๋Œ€ํ•œ ์„ค๋ช…์„ ์ฃผ์„์œผ๋กœ ์ถ”๊ฐ€ํ•จ
@CU7103
Chore: ๋””๋ ‰ํ† ๋ฆฌ ๋ณ€๊ฒฝ ๋ฐ ์ฝ”๋“œ ์‚ญ์ œ
1bf0da7 
p6spy ๋””๋ ‰ํ„ฐ๋ฆฌ ๋ณ€๊ฒฝ๊ณผ ๋ถˆํ•„์š”ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์‚ญ์ œ
@CUCU7103 CUCU7103 requested a review from f-lab-jd November 23, 2024 09:17
@CUCU7103 CUCU7103 self-assigned this Nov 23, 2024
@f-lab-jd
Copy link
Collaborator

ํ˜„์žฌ PR ์— ์ด์ „ PR ์— ์˜ฌ๋ฆฐ ๋‚ด์šฉ๋„ ํฌํ•จ์ด ๋˜์–ด์žˆ์Šต๋‹ˆ๋‹ค.
๋ถ„๋ฆฌํ•ด์„œ PR ์„ ๋‹ค์‹œ ์˜ฌ๋ ค์ฃผ์‹œ๊ฑฐ๋‚˜, target branch ๋ฅผ ์ด์ „ PR ๋ธŒ๋žœ์น˜๋กœ ๋ณ€๊ฒฝํ•ด์„œ ๋‹ค์‹œ ์˜ฌ๋ ค์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@CUCU7103 CUCU7103 changed the base branch from develop to feature_login November 23, 2024 18:11
@CUCU7103
Copy link
Collaborator Author

target branch ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค!

Base automatically changed from feature_login to feature_join December 10, 2024 13:19
@CU7103
Chore: ๋ˆ„๋ฝ๋œ import๋ฌธ ์ถ”๊ฐ€
7e926ef 
๋ˆ„๋ฝ๋œ import๋ฌธ ์ถ”๊ฐ€
@CU7103
Merge remote-tracking branch 'origin/feature_join' into feature_annotโ€ฆ
2b40385 
โ€ฆation

๋ณ‘ํ•ฉ ์ถฉ๋Œ ํ•ด๊ฒฐ
@CUCU7103 CUCU7103 merged commit a51d5fd into feature_join Dec 10, 2024
1 check passed
@CUCU7103 CUCU7103 deleted the feature_annotation branch December 10, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-jd f-lab-jd f-lab-jd approved these changes

Assignees

@CUCU7103 CUCU7103

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CUCU7103 @f-lab-jd @CU7103