Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'saltbox venv exec' usage not traceable to codebase or generated code #9

Open
JeffreyUrban opened this issue Sep 17, 2020 · 0 comments

Comments

@JeffreyUrban
Copy link

JeffreyUrban commented Sep 17, 2020

The F0cal codebase makes frequent use of saltbox venv exec. Usages are difficult to trace back to code, because stdout/stderr from calling these entrypoints contains only the results of the operation, but no details of what top-level operation is being performed or what generated code is being used.

Troubleshooting such usage regularly devolves to a reverse engineering search effort to discover candidates for what code is behind the output. The included salt steps often provide clues to which top-level operation is being called, but often the same steps are used in multiple entrypoints, leading to the wrong code, or to ambiguity, or the steps are composed of generated code whose source path is indeterminable and whose content is not traceable back to the codebase.

Suggest adding output to all usage of _venv_exec to include the identity of the saltbox function, and the path to any generated code being used, such that all use is traceable to the codebase and to any generated code.

saltbox/src/saltbox/venv.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant