-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move edt as part of track asset #117
base: v1.0.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, but have a few questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I would integrate the creation of EDT directly into the track loading.
We can keep this as an example anyway or get rid of it.
@hzheng40 I have added a test for a kind of corner case we discussed in the last meeting. The changes proposed should address it. Scenario: Current behavior: Expected behavior: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of changes necessary
@@ -0,0 +1,41 @@ | |||
from f110_gym.envs.track import Track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from f110_gym.envs.track import Track | |
from f1tenth_gym.envs.track import Track |
@@ -24,7 +24,7 @@ def find_track_dir(track_name: str) -> pathlib.Path: | |||
FileNotFoundError | |||
if no map directory matching the track name is found | |||
""" | |||
map_dir = pathlib.Path(__file__).parent.parent.parent.parent / "maps" | |||
map_dir = pathlib.Path(__file__).parent.parent.parent.parent.parent / "maps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this? it does not point to the right "maps" directory in this way
map_dir = pathlib.Path(__file__).parent.parent.parent.parent.parent / "maps" | |
map_dir = pathlib.Path(__file__).parent.parent.parent.parent / "maps" |
Addresses #107
set_map()