Skip to content

Commit

Permalink
review again
Browse files Browse the repository at this point in the history
  • Loading branch information
Meakk committed Nov 27, 2024
1 parent 18a4e8c commit 50b5d2c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/actions/imgui-install-dep/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ runs:
uses: actions/cache@v4
with:
path: dependencies/imgui_install
key: imgui-v1.91.5-${{runner.os}}-${{inputs.cpu}}-2
key: imgui-v1.91.5-${{runner.os}}-${{inputs.cpu}}-3

- name: Checkout ImGui
if: steps.cache-imgui.outputs.cache-hit != 'true'
Expand Down
6 changes: 2 additions & 4 deletions application/testing/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -803,10 +803,8 @@ f3d_test(NAME TestProgress DATA cow.vtp ARGS --progress NO_BASELINE)
f3d_test(NAME TestProgressScene DATA WaterBottle.glb ARGS --progress NO_BASELINE)
f3d_test(NAME TestInteractionProgressReload DATA cow.vtp ARGS --progress NO_BASELINE INTERACTION) #Up;Up;Up;Up

# For some reasons this animation test goes "too far" when run with sanitizer
if(F3D_SANITIZER STREQUAL "none")
f3d_test(NAME TestInteractionCycleAnimation DATA InterpolationTest.glb INTERACTION THRESHOLD 0.06) #WWWWWWWWWWW;Space;Space;
endif()
# This test is not reliable since dependending on the local performance, different frames can be captured

Check failure on line 806 in application/testing/CMakeLists.txt

View workflow job for this annotation

GitHub Actions / Codespell Check

dependending ==> depending
# f3d_test(NAME TestInteractionCycleAnimation DATA InterpolationTest.glb INTERACTION) #WWWWWWWWWWW;Space;Space;
f3d_test(NAME TestInteractionCycleAnimationNoAnimation DATA cow.vtp INTERACTION NO_BASELINE) #W

f3d_test(NAME TestInteractionDropFiles ARGS -n INTERACTION_CONFIGURE UI)#X;DropEvent cow.vtp;DropEvent dragon.vtu suzanne.stl;
Expand Down

0 comments on commit 50b5d2c

Please sign in to comment.