Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit dosnt work when manually selecting items in code #36

Open
SmileymanDK opened this issue Jan 23, 2020 · 3 comments
Open

Limit dosnt work when manually selecting items in code #36

SmileymanDK opened this issue Jan 23, 2020 · 3 comments

Comments

@SmileymanDK
Copy link

when automaticly selecting items in code using the "Selected" value, the selected items is updating.. however, if there is a limit, and the selected number hits the limit, the rest isnt disabled as they are when im selecting it manually with the mouse.
If i deselect and item and select it again, the limit function triggers.

Is it possible to fix that or maybe have a go around? :-)

@fabianlindfors
Copy link
Owner

Hi!

Unfortunately I can't see a quick fix for this right now. It would require some restructuring of the code and I don't really have much time to spend on multi.js right now. If you want to have a go at it and create a PR though I'd be happy to merge it!

@bmcorum
Copy link
Contributor

bmcorum commented Jan 4, 2021

@fabianlindfors with the refactoring done in #45 this could be possible now. Not sure if we should just expose the new check_limit function or if it would be as simple as updating the event listener for the select change event to call check_limit before calling refresh_select.

@SmileymanDK
Copy link
Author

With the amount of work I currently have on other projects, I found another solution back then :-) And since its more than 9 months ago and i dont have access to the project anymore, , I already forgot what the solution was :-) Ill keep watch on it though, in case i need it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants