Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test depends on https://sso.prod-preview.openshift.io #193

Open
hferentschik opened this issue Mar 13, 2018 · 0 comments
Open

Test depends on https://sso.prod-preview.openshift.io #193

hferentschik opened this issue Mar 13, 2018 · 0 comments
Labels
kind/task priority/major

Comments

@hferentschik
Copy link
Contributor

The test in main_test.go depends on https://sso.prod-preview.openshift.io. Unit tests should not depend on external services. So either we find a way to change this, or we remove this particular test altogether. After all, it does not really assert much. It just shows that the Proxy starts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task priority/major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hferentschik