Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Description #48

Open
BartBucknill opened this issue Nov 3, 2017 · 1 comment
Open

Test Description #48

BartBucknill opened this issue Nov 3, 2017 · 1 comment

Comments

@BartBucknill
Copy link

Overall looks like great tests, especially in deleteToDo.test.js and markToDo.test.js.
Small point is that in markToDo.test.js, I think one of the test descriptions may be incorrect:

 test('Function returns dummyArr minus id #1', function(t) {

  t.deepEquals(logic.markTodo(dummyMarkArr,1),dummyArrMark1,'Function marks id #1 as done.');
  t.end();
  });
@BartBucknill
Copy link
Author

BartBucknill commented Nov 3, 2017

@shannonjensen is this actually closed? Just checked the code and it seems to be unchanged on master. When closing an issue best to reference the commit message that closes it and only close after merging into master.

@shannonjensen shannonjensen reopened this Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants