Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary class components #21

Closed
oliverjam opened this issue Feb 1, 2019 · 2 comments
Closed

Unnecessary class components #21

oliverjam opened this issue Feb 1, 2019 · 2 comments

Comments

@oliverjam
Copy link

I understand it's probably just copy/paste duplication that you haven't got around to fixing, but I thought I'd point it out anyway.

Your only stateful component is the App, so it would be simpler for all the others to be function components that render JSX based on their props.
@helenzhou6
Copy link

Note this is the same issue as: #18

@oliverjam
Copy link
Author

Sorry for the duplicate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliverjam @helenzhou6