Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script.js #32

Open
tonylomax opened this issue Aug 23, 2019 · 1 comment
Open

script.js #32

tonylomax opened this issue Aug 23, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@tonylomax
Copy link

Do you need the promise in this?

if (selectDropDown) {
  const category = selectDropDown.value;
  document.querySelector("#categoryButton").addEventListener("click", e => {
    e.preventDefault();
    fetch(`/quotes/searchcategory/${category}`).then(response =>
    );
  });
}

It looks like it's just console logging, i tried deleting it and everything looks like it's still working

@tonylomax tonylomax added the enhancement New feature or request label Aug 23, 2019
@rooberrydev
Copy link
Contributor

that whole fetch isnt doing what we're expecting haha. gonna rewrite this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants