Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Love the quiz, hate losing. #24

Open
jokosanyang opened this issue Sep 27, 2019 · 0 comments
Open

Love the quiz, hate losing. #24

jokosanyang opened this issue Sep 27, 2019 · 0 comments

Comments

@jokosanyang
Copy link

Really cool idea, with HELLA categories. There's one for everybody.

Here are some tiny easy fixes:

  • Typo on the main page:
    Screenshot from 2019-09-27 11-12-26
  • You've set the hover on all buttons, so you don't need to repeat that for individual buttons:
    Screenshot from 2019-09-27 11-15-45
  • This doesn't need as many props as you've passed. The button & setButton is only used in this component, so you can move the whole useState in. The username and page props are not used, so they don't need to be passed in either.
    Screenshot from 2019-09-27 11-23-41

Ps. don't forget to delete the console.logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant