Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Did you use cors? #26

Open
jackbridger opened this issue Jul 19, 2019 · 1 comment
Open

Did you use cors? #26

jackbridger opened this issue Jul 19, 2019 · 1 comment
Assignees
@jackbridger @sarahyjja
Labels
question Further information is requested

Comments

@jackbridger
Copy link

I know cors is the optional third argument in your request function

Correct me if I'm wrong but all of your functions have two arguments though so do you need cors?
@sarahyjja
Copy link
Contributor

You right, we are not using CORS in our project.
I think you saw in our code a function related to it. Our idea was to pass by this function as a proxy and returning us the API without the restrictions. We decided to use it for a weather API at the beginning but we drop the idea as we were looking for API without keys, so can be hosted on GitHubPage and seen by everyone.
So actually, if we didn't already, we should get rid of this function 😉

@sarahyjja sarahyjja added the question Further information is requested label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackbridger jackbridger

@sarahyjja sarahyjja

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackbridger @sarahyjja