You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👍 logical, neat file structure
🧹 nice, clean styling
🛸 I like the hover effect on each cheese and that the whole card is a link - good for accessibility
💅 CSS file was quite tidy and made sense in terms of where you put the class styles on the page
🐤 you've used getStaticProps and getStaticPaths :)
🥝 would have liked to see getServerSideProps for data that will change like quantity of products available (which I realise isn't in your DB schema)
📚 database schema looks good and makes sense - are you linking users to any other table?
😕 i notice the single product pages are determined by the cheese name. This results in spaces in the URL.. which doesn't sit right
😿 Would have liked to see a test
📖 README could have instructions on setting up locally, i.e. what variables you need in the .env.local and how to set up the local database (without including secrets)
💇 In terms of semantic HTML, I would make some small changes to improve it. The filter section might be better as an aside. There's a navbar class on a header component..
❓ I wanted to ask why you used dangerouslySetInnerHTML in the [id].js file
❔ Why the react-cookie package?
Ultimately, you've done so well. It was a tough project and week and look at how much you've learnt and managed to fix! 💐 🌷 So keep going! 💪
The text was updated successfully, but these errors were encountered:
👍 logical, neat file structure
🧹 nice, clean styling
🛸 I like the hover effect on each cheese and that the whole card is a link - good for accessibility
💅 CSS file was quite tidy and made sense in terms of where you put the class styles on the page
🐤 you've used
getStaticProps
andgetStaticPaths
:)🥝 would have liked to see
getServerSideProps
for data that will change like quantity of products available (which I realise isn't in your DB schema)📚 database schema looks good and makes sense - are you linking users to any other table?
😕 i notice the single product pages are determined by the cheese name. This results in spaces in the URL.. which doesn't sit right
😿 Would have liked to see a test
📖 README could have instructions on setting up locally, i.e. what variables you need in the .env.local and how to set up the local database (without including secrets)
💇 In terms of semantic HTML, I would make some small changes to improve it. The filter
section
might be better as anaside
. There's anavbar
class on aheader
component..❓ I wanted to ask why you used
dangerouslySetInnerHTML
in the[id].js
file❔ Why the
react-cookie
package?Ultimately, you've done so well. It was a tough project and week and look at how much you've learnt and managed to fix! 💐 🌷 So keep going! 💪
The text was updated successfully, but these errors were encountered: