Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More code review stuff #35

Open
aissshah opened this issue May 21, 2021 · 0 comments
Open

More code review stuff #35

aissshah opened this issue May 21, 2021 · 0 comments

Comments

@aissshah
Copy link

👍 logical, neat file structure
🧹 nice, clean styling
🛸 I like the hover effect on each cheese and that the whole card is a link - good for accessibility
💅 CSS file was quite tidy and made sense in terms of where you put the class styles on the page
🐤 you've used getStaticProps and getStaticPaths :)
🥝 would have liked to see getServerSideProps for data that will change like quantity of products available (which I realise isn't in your DB schema)
📚 database schema looks good and makes sense - are you linking users to any other table?
😕 i notice the single product pages are determined by the cheese name. This results in spaces in the URL.. which doesn't sit right
😿 Would have liked to see a test
📖 README could have instructions on setting up locally, i.e. what variables you need in the .env.local and how to set up the local database (without including secrets)
💇 In terms of semantic HTML, I would make some small changes to improve it. The filter section might be better as an aside. There's a navbar class on a header component..

❓ I wanted to ask why you used dangerouslySetInnerHTML in the [id].js file
❔ Why the react-cookie package?

Ultimately, you've done so well. It was a tough project and week and look at how much you've learnt and managed to fix! 💐 🌷 So keep going! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant