From 5c948a963461bd08bd6a65e09931c12ed89ae2aa Mon Sep 17 00:00:00 2001 From: Sait Cakmak Date: Tue, 16 Apr 2024 14:13:38 -0700 Subject: [PATCH] Silence fit tracking metrics logs in BenchmarkMethod (#2370) Summary: Pull Request resolved: https://github.com/facebook/Ax/pull/2370 These warnings appear many times when running benchmark tests. Since tests have a logger level of warning, making these into info logs will have them appear in regular usage while silencing them in tests. {F1488198739} Reviewed By: esantorella Differential Revision: D56199058 fbshipit-source-id: 560243228d200abf297ae959ac2ee8bbaf53ab7f --- ax/benchmark/benchmark_method.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ax/benchmark/benchmark_method.py b/ax/benchmark/benchmark_method.py index d12b0df675f..8bfee47415f 100644 --- a/ax/benchmark/benchmark_method.py +++ b/ax/benchmark/benchmark_method.py @@ -45,7 +45,7 @@ def __post_init__(self) -> None: # the benchmark - in fact, things will error out deep inside the modeling # stack since the model gets both noisy (benchmark) and noiseless (ground # truth) observations. While support for this is something we shold add - # or models, in the context of benchmarking we actually want to avoid + # for models, in the context of benchmarking we actually want to avoid # fitting the ground truth metrics at all. # Clone the GS so as to not modify the original one in-place below. @@ -57,7 +57,7 @@ def __post_init__(self) -> None: if node.model_kwargs is None: node.model_kwargs = {} if node.model_kwargs.get("fit_tracking_metrics", True): - logger.warning( + logger.info( "Setting `fit_tracking_metrics` in a GenerationStep to False.", ) not_none(node.model_kwargs)["fit_tracking_metrics"] = False @@ -65,7 +65,7 @@ def __post_init__(self) -> None: if model_spec.model_kwargs is None: model_spec.model_kwargs = {} elif model_spec.model_kwargs.get("fit_tracking_metrics", True): - logger.warning( + logger.info( "Setting `fit_tracking_metrics` in a GenerationNode's " "model_spec to False." )