Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to docusaurus 2 #466

Closed
davidjgoss opened this issue Jan 5, 2021 · 5 comments
Closed

migration to docusaurus 2 #466

davidjgoss opened this issue Jan 5, 2021 · 5 comments
Labels
enhancement New feature or request wishlist Long-term wishlist feature requests

Comments

@davidjgoss
Copy link

As part of an effort to roll out Docusaurus 2 and test its site migration tools, would you be okay with having me (or somebody else) do a PR that migrates the Ax website to Docusaurus 2?

@ldworkin
Copy link
Contributor

ldworkin commented Jan 5, 2021

Hi @davidjgoss! Sure, this sounds good to me. Are there any downsides to it? I can't think of a reason why this would be a problem, but I'm also not very familiar with Docusaurus.

@Balandat
Copy link
Contributor

Balandat commented Jan 5, 2021

When we looked at this in the past, one issue was that we do some manual versioning of the whole site (incl. tutorials and Sphnix-generated API docs), and docusaurus2 at the time wasn't able to properly support that. So we want to make sure that the functionality remains as is (or gets better) with the migration.

If you are considering migrating Ax, please also consider migrating pytorch/botorch, as the site setup is essentially the same as for Ax.

@davidjgoss
Copy link
Author

@ldworkin @Balandat looking at the current site I don't think there should be any blockers. Versioning wasn't there in the earlier alphas but is well supported now including by the migration tooling. i18n is still not there but I don't think the Ax site uses that?

@Balandat
Copy link
Contributor

Balandat commented Jan 5, 2021

Just to be clear, this is versioning for externally include sites such as the tutorials and the sphinx-autogenerated html code that we stick into the site. This versioning happens in https://github.com/facebook/Ax/blob/master/scripts/publish_site.sh. We do not use i18n.

@ldworkin ldworkin added the enhancement New feature or request label Jan 7, 2021
@lena-kashtelyan lena-kashtelyan added the wishlist Long-term wishlist feature requests label Apr 21, 2021
@lena-kashtelyan
Copy link
Contributor

We will now be tracking wishlist items / feature requests in a master issue for improved visibility: #566. Of course please feel free to still open new feature requests issues; we'll take care of thinking them through and adding them to the master issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wishlist Long-term wishlist feature requests
Projects
None yet
Development

No branches or pull requests

4 participants