Skip to content

Commit

Permalink
Fix external deps test
Browse files Browse the repository at this point in the history
Summary: Broken by D66377231

Reviewed By: IanChilds

Differential Revision: D66498117

fbshipit-source-id: c2de92d6ebd2753626f9b433de43794eeabddd83
  • Loading branch information
Ioan Budea authored and facebook-github-bot committed Nov 26, 2024
1 parent 2374a1e commit 2caeefc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion tests/core/build/test_executor_with_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ async def test_good_target_with_dependencies(buck: Buck) -> None:
assert len(deps) == 1
assert deps[0]["smc_tier"] == "noop"
assert deps[0]["id"] == "foo"
assert deps[0]["reservation_id"] == "noop"
# reservation_id is a random string which is 20 characters long
assert len(deps[0]["reservation_id"]) == 20

# Make sure it actually did run on RE.
out = await read_what_ran(buck)
Expand Down
3 changes: 2 additions & 1 deletion tests/e2e/build/test_build_inplace.py
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,8 @@ async def test_genrule_with_remote_execution_dependencies(buck: Buck) -> None:
assert len(deps) == 1
assert deps[0]["smc_tier"] == "noop"
assert deps[0]["id"] == "foo"
assert deps[0]["reservation_id"] == "noop"
# reservation_id is a random string which is 20 characters long
assert len(deps[0]["reservation_id"]) == 20


async def read_io_provider_for_last_build(buck: Buck) -> None:
Expand Down

0 comments on commit 2caeefc

Please sign in to comment.