Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SwiftPM configuration by pointing to v16.2.0 instead of v16.1.3 #2284

Closed
wants to merge 1 commit into from

Conversation

ruipfcosta
Copy link

@ruipfcosta ruipfcosta commented Oct 11, 2023

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

This PR fixes an issue where the SwiftPM configuration was pointing to version 16.1.3, even though the SDK had already been incremented to version 16.2.0. This would cause clients to assume version 16.2.0 had been integrated via SwiftPM when in reality version 16.1.3 was the one being linked.

Test Plan

Integrate the SDK on a sample app and verify the correct version was linked.

@ruipfcosta ruipfcosta requested a review from joesus as a code owner October 11, 2023 13:48
@facebook-github-bot
Copy link
Contributor

Hi @ruipfcosta!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@romarealmreborn
Copy link

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

This PR fixes an issue where the SwiftPM configuration was pointing to version 16.1.3, even though the SDK had already been incremented to version 16.2.0. This would cause clients to assume version 16.2.0 had been integrated via SwiftPM when in reality version 16.1.3 was the one being linked.

Test Plan

Integrate the SDK on a sample app and verify the correct version was linked.

@KOREANO88
Copy link

Gracias apenas empiezo a utilizarlo gracias

@maruf4242
Copy link

I like this

@github-actions github-actions bot added the Stale label May 16, 2024
@github-actions github-actions bot closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants