Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is live but only approved testers can login (using limited login on 17.0.0) #2387

Open
5 tasks done
rgg-egunnery opened this issue Apr 17, 2024 · 62 comments
Open
5 tasks done

Comments

@rgg-egunnery
Copy link

Checklist before submitting a bug report

Xcode version

15.3

Facebook iOS SDK version

17.0.0

Dependency Manager

SPM

SDK Framework

Login

Goals

Login for all users

Expected results

I expect both test users and regular users to be handled correctly when the app is live.

Actual results

I keep getting a cancellation returned when trying to use the new login method for limited login, only for non test users.

Steps to reproduce

No response

Code samples & details

self?.loginManager.logIn(configuration: configuration) { result in
                switch result {
                case .cancelled:
                    continuation.resume(throwing: Cancelation()) <--- hits every time I try login from a non tester account
                }
            }
@fgeracitano
Copy link

Any news on this one?

@bluerainxty
Copy link

same

@alexwind-lin
Copy link

same

@giorgia
Copy link

giorgia commented Apr 23, 2024

same

@tommy6457
Copy link

same here

1 similar comment
@kishore-chandru-poshmark

same here

@rgg-clineu
Copy link

rgg-clineu commented Apr 25, 2024

any updates?

@hollyShine
Copy link

same,and I had to drop the version to 16.3.1

@bluerainxty
Copy link

any updates?

@alexEulerity
Copy link

same,and I had to drop the version to 16.3.1

Don't we need version 17.0.0 to conform to Apple's Privacy Policy, since version 17.0.0 has the Policy Privacy File?

@chorobochrontochor
Copy link

+1

@rgg-egunnery
Copy link
Author

Just confirming that this is also the case on 17.0.1

@gupta515
Copy link

gupta515 commented May 3, 2024

same,and I had to drop the version to 16.3.1

Don't we need version 17.0.0 to conform to Apple's Privacy Policy, since version 17.0.0 has the Policy Privacy File?

+1

@gupta515
Copy link

gupta515 commented May 3, 2024

same,and I had to drop the version to 16.3.1

Did your build pass through Apple's Privacy Policy check?

@SamuelZhaoY
Copy link

same!, and

Just confirming that this is also the case on 17.0.1

yes, same on 17.0.1

@SamuelZhaoY
Copy link

SamuelZhaoY commented May 5, 2024

Our company have more than 10 FB Application, after migrating to iOS FBSDK 17.0.0.
We found that when using one of the Facebook AppID and ClientToken, the following method always return result with isCancelled = true.

- (void)logInFromViewController:(UIViewController * _Nullable)viewController 
                                configuration:(FBSDKLoginConfiguration * _Nullable)configuration 
                                    completion:(FBSDKLoginManagerLoginResultBlock _Nonnull)completion;

What makes our team confused is that:

  • Previously when using the 16.2.1 version of the SDK, the FB App configuration is working fine. Now the issue happens for both 17.0.0 and 17.0.1
  • The rest of the FB App configurations (around 10) is working fine, yet the single FB App has such issue 🤔️
  • For the same xcode workspace, as soon as we change the FacebookClientToken/FacebookAppID and the URL in the app's info.plist , things can work as expected.

Not sure it is a bug in the Facebook Login SDK or any potential misconfiguration on the Facebook Developer console

FBSDKLoginManager *login = [[FBSDKLoginManager alloc] init];
FBSDKLoginConfiguration *configuration = [[FBSDKLoginConfiguration alloc]
                                               initWithPermissions:@[@"public_profile", @"email"]
                                               tracking:FBSDKLoginTrackingLimited];
[login logInFromViewController:[UITool getCurrentVC]
                              configuration:configuration
                                  completion:^(FBSDKLoginManagerLoginResult * _Nullable result, NSError * _Nullable error) {
        if (error) {
            // error
        } else if (result.isCancelled) {
            //
            // this is the code always goes to under one
            // of the specific fb app configuration
            // 
        } else {
            // success, which should be expected
        }
        callback(responseDic);
    }];

Update:

  • Similarly, when using test account / developer account, the login flow can succeed

@hollyShine
Copy link

same,and I had to drop the version to 16.3.1

Did your build pass through Apple's Privacy Policy check?

passed

@hollyShine
Copy link

same,and I had to drop the version to 16.3.1

Don't we need version 17.0.0 to conform to Apple's Privacy Policy, since version 17.0.0 has the Policy Privacy File?

16.3.1 build passed through Apple's check for me

@rgg-egunnery
Copy link
Author

We had a call with Facebook last Thursday to discuss this and I've sent them the logs I collected for success vs failure for test and public accounts. They had no solution to offer on the call for this, but I will update this thread if I hear anything further.

@fgeracitano
Copy link

their latest suggestion is: "you need to submit for review"

  • the app was working for 16.3.1 for public users
  • the app is in published state already
  • the is no submit for review button if you ask only basic email / public profile
  • they state "Most permissions must be approved"

if that is the real problem there must be a bug on their review app flow

@BunLV
Copy link

BunLV commented May 13, 2024

I tested with many fb app and i see: with fb app go live, if fb sdk ios version on "App Settings/Advanced/Check your SDK version":

  • fb sdk version 15.x or later => its worked
  • fb sdk version under 15.x => always return cancel

I hope it can help fb developer team detect this issue.

@mrhodangduy
Copy link

I tested with many fb app and i see: with fb app go live, if fb sdk ios version on "App Settings/Advanced/Check your SDK version":

  • fb sdk version 15.x or later => its worked
  • fb sdk version under 15.x => always return cancel

I hope it can help fb developer team detect this issue.

Screenshot 2024-05-13 at 13 50 46

In my FB App Setting, it display like that. What's wrong?

@fgeracitano
Copy link

I tested with many fb app and i see: with fb app go live, if fb sdk ios version on "App Settings/Advanced/Check your SDK version":

  • fb sdk version 15.x or later => its worked
  • fb sdk version under 15.x => always return cancel

I hope it can help fb developer team detect this issue.

Screenshot 2024-05-13 at 13 50 46 In my FB App Setting, it display like that. What's wrong?

It's a know problem on their side, they don't keep track of the latest release, and that piece of UI tands to bring even more confusion 🤦

Screenshot 2024-05-13 at 12 35 27 PM

@marcin-piela-800
Copy link

We have iOS v15.0.0 and it's not working

@xsgoing
Copy link

xsgoing commented May 14, 2024

same in V17.0.1

@kiyakkoray
Copy link

Update: I jumped the gun. We have two apps, the first was working and the second was not. We contacted them again and now the second is working. It appears this needs to be fixed on a per app basis, presumably just some configuration on their end.

Do they at least know that this is a common problem and are they trying to fix it?

@marcin-piela-800
Copy link

Update: I jumped the gun. We have two apps, the first was working and the second was not. We contacted them again and now the second is working. It appears this needs to be fixed on a per app basis, presumably just some configuration on their end.

How did you contact them? It's not very straightforward...We have informed them about this problem several times with each app rejection, but it seems like it is a bot, not a human...

@rgg-egunnery
Copy link
Author

rgg-egunnery commented May 20, 2024

Do they at least know that this is a common problem and are they trying to fix it?

I have stressed that this is a widespread issue and asked the check out all these raised issues. Given they had to do a separate fix for each of our apps, I think they're likely working on a fix for the SDK as a hole and this was just a stop gap as we were able to contact them. Even if they do believe this is low impact, I am hopeful they don't think it's reasonable to just keep fixing apps one by one.

How did you contact them? It's not very straightforward...We have informed them about this problem several times with each app rejection, but it seems like it is a bot, not a human...

We have an account manager for Facebook so one of our product managers was able to reach out.

@haryelramalho
Copy link

Does anyone know how I can disable limited login? Because I need the access token to make some requests to graph API...

@daleiLV
Copy link

daleiLV commented May 23, 2024

I have two app,they have same sdk version image but only one worked ,one not。 @BunLV and my sdk version is V17.0.1

您好,该问题解决了吗?如果解决了,怎么解决的呢?

@xsgoing
Copy link

xsgoing commented May 23, 2024

not yet

@rgg-egunnery
Copy link
Author

Does anyone know how I can disable limited login? Because I need the access token to make some requests to graph API...

You can't. You can set the login configuration to .enabled (which it does by default anyway) or to .limited. If set to .enabled, if the user has tracking completely disabled on device it'll still route to .limited. Facebook's documentation goes through how to handle this case vs .enabled, and it does work for test accounts, but the wall was hit for us with public accounts. Facebook had to fix each of our apps on a case by case basis for this, something was done on their end.

@EvansPie
Copy link

Same in v.17.0.2

@kaancembertas
Copy link

Same here

@gupta515
Copy link

Same in v.17.0.2

Yes, even it is same in the tag 17.0.2, though we are passing the transaction mode as .enabled it is still loading .limited. It's already been weeks waiting for the stable version from Facebook.

@kiyakkoray
Copy link

any workaround yet?

@bluerainxty
Copy link

这么久了,也没人解决

@margarethchan
Copy link

Has anyone other than OP successfully "unlocked" their apps via Meta Account Manager contact?

@omz1990
Copy link

omz1990 commented Jun 6, 2024

Really annoying. Reverting to old version brings back this issue: #2353
So basically either we downgrade Xcode to 15.2 or break Facebook login. Great!!!

@Akles
Copy link

Akles commented Jun 11, 2024

Any updates?

@Adnan46
Copy link

Adnan46 commented Jun 20, 2024

any solution?

@StriderHND
Copy link

Hello guys any updates on this?

@kiyakkoray
Copy link

still no update?

@aguzmanrebuy
Copy link

I wonder if this is actually the same issue as #2365.
If so, then the solution would be to support the limited log in ?

@kiyakkoray
Copy link

still no update?

any solution?

@trickeyd
Copy link

trickeyd commented Aug 9, 2024

I filled this out in regard to this issue - still waiting for a response.

https://go.facebookinc.com/2018-FB4D-platform-review-form.html

@gupta515
Copy link

gupta515 commented Aug 9, 2024

Any update?

@MaxJadav
Copy link

I'm getting the same issue. Is there any update?

@pw-repo
Copy link

pw-repo commented Sep 1, 2024

Have anyone make it succesful to login with production real users with SDK v17.0+?

@pw-repo
Copy link

pw-repo commented Sep 3, 2024

Update: I jumped the gun. We have two apps, the first was working and the second was not. We contacted them again and now the second is working. It appears this needs to be fixed on a per app basis, presumably just some configuration on their end.

Does it work now in September 2024 correctly?

I need to upgrade Facebook SDK to 17.1.3 version to use Privacy Manifest files to pass the App Store review.

@pw-repo
Copy link

pw-repo commented Sep 3, 2024

I filled this out in regard to this issue - still waiting for a response.

https://go.facebookinc.com/2018-FB4D-platform-review-form.html

Have you received a response from Facebook?

@trickeyd
Copy link

trickeyd commented Sep 4, 2024

No I heard nothing nothing either @pw-repo . Additionally I have tried various other avenues and have had some of the most infuriating conversations with people from Meta.

No one is owning this. We are just having to migrate our users and remove FB login. It is ridiculous.

@angelolloqui
Copy link

angelolloqui commented Oct 14, 2024

What an annoying issue! I have no idea why the IDFA should prevent users from doing a FB login, but it makes no sense to me!

Probably not the most robust solution (and I need to verify FB's terms of use are not broken), but I have made this simple drop in replacement for the LoginManager that uses the ASWebAuthenticationSession following the manual login flow instructions found in their official documentation.

You can use it like this:

 FacebookSignInHelper.login(permissions: permissions, from: self) { result in
            switch result {
            case let .success(result):
                  // use result.accessToken, result.grantedPermissions
            case let .failure(error):
                Log.e("OnboardingAuthViewController", "Facebook login error: \(error.localizedDescription)")
            }
        }

No other setup is needed if you were previously using the FB Login SDK already...

I hope it helps someone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests