Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't Load Any image with excluded nativeimagetranscoder #2402

Closed
zetbrush opened this issue Sep 5, 2019 · 3 comments
Closed

Doesn't Load Any image with excluded nativeimagetranscoder #2402

zetbrush opened this issue Sep 5, 2019 · 3 comments

Comments

@zetbrush
Copy link

zetbrush commented Sep 5, 2019

https://cdn1.imggmi.com/uploads/2019/9/5/dd8b729a2a160140f0f2849020b2d62b-full.png
to eliminate issues described in #2049 (comment) and using configurations using steps mentioned in above comment, we are getting getNativeImageTranscoder thrown an exception (as nativeImageTranscoder have been excluded) and the fallback to SimpleImageTranscoder never reaches, so no image can be loaded

Reproduction

use excluding nativeimagetranscoder module solution described and approved in #2049 (comment)

Solution

[thrown exception should be handled in order to continue execution to SimpleImageTranscoder fallback ]

Additional Information

  • Fresco version: 2.0.0
  • Platform version: [Pixel 3, Android 10]
@zetbrush
Copy link
Author

zetbrush commented Sep 5, 2019

@tyronen @oprisnik hey, can you check this out pls?

@zetbrush
Copy link
Author

zetbrush commented Sep 5, 2019

Solution: add
ImagePipelineConfig.Builder:: setImageTranscoderType(ImageTranscoderType.JAVA_TRANSCODER); #2049 (comment)

@oprisnik
Copy link
Contributor

oprisnik commented Sep 5, 2019

Cool, I'll close this then. We're also working on a Java-only Fresco version, so this should be much easier soon.

@oprisnik oprisnik closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants