From c25f770ad9f10f072fcce6613edad2ad2889a101 Mon Sep 17 00:00:00 2001
From: Rob Hogan <robhogan@meta.com>
Date: Sat, 21 Dec 2024 06:52:42 -0800
Subject: [PATCH] Watcher backends: remove unused event types

Summary:
Currently watcher backends, which extend `EventEmitter`, emit two events for any file change:
 - One with event name `change`/`add`/`delete`
 - One with event name `all`, and `change`/`add`/`delete` in the payload.

We only ever listen to `all`. The former type is neither exercised nor tested. This removes the unused events.

Changelog: Internal

Reviewed By: hoxyq

Differential Revision: D67393484

fbshipit-source-id: 9ef824710be5f88f8e7d5462e37b076fe5aa0847
---
 packages/metro-file-map/src/watchers/FSEventsWatcher.js | 1 -
 packages/metro-file-map/src/watchers/NodeWatcher.js     | 1 -
 packages/metro-file-map/src/watchers/WatchmanWatcher.js | 1 -
 3 files changed, 3 deletions(-)

diff --git a/packages/metro-file-map/src/watchers/FSEventsWatcher.js b/packages/metro-file-map/src/watchers/FSEventsWatcher.js
index 67962a0423..0117eaec31 100644
--- a/packages/metro-file-map/src/watchers/FSEventsWatcher.js
+++ b/packages/metro-file-map/src/watchers/FSEventsWatcher.js
@@ -194,7 +194,6 @@ export default class FSEventsWatcher extends EventEmitter {
     file: string,
     metadata?: ChangeEventMetadata,
   ) {
-    this.emit(type, file, this.root, metadata);
     this.emit(ALL_EVENT, type, file, this.root, metadata);
   }
 
diff --git a/packages/metro-file-map/src/watchers/NodeWatcher.js b/packages/metro-file-map/src/watchers/NodeWatcher.js
index 183d99b1dd..65cf44c9ad 100644
--- a/packages/metro-file-map/src/watchers/NodeWatcher.js
+++ b/packages/metro-file-map/src/watchers/NodeWatcher.js
@@ -395,7 +395,6 @@ module.exports = class NodeWatcher extends EventEmitter {
     file: string,
     metadata: ?ChangeEventMetadata,
   ) {
-    this.emit(eventType, file, this.root, metadata);
     this.emit(ALL_EVENT, eventType, file, this.root, metadata);
   }
 
diff --git a/packages/metro-file-map/src/watchers/WatchmanWatcher.js b/packages/metro-file-map/src/watchers/WatchmanWatcher.js
index 3a0d571337..bc7f852892 100644
--- a/packages/metro-file-map/src/watchers/WatchmanWatcher.js
+++ b/packages/metro-file-map/src/watchers/WatchmanWatcher.js
@@ -308,7 +308,6 @@ export default class WatchmanWatcher extends EventEmitter {
     root: string,
     changeMetadata?: ChangeEventMetadata,
   ) {
-    this.emit(eventType, filepath, root, changeMetadata);
     this.emit(ALL_EVENT, eventType, filepath, root, changeMetadata);
   }