You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
#845
This pull request introduces a new StepLogger API to simplify and standardize the logging and performance measurement process in the Pysa taint analysis codebase. By encapsulating common patterns of starting timers, logging information, and recording performance metrics, this API helps to reduce code duplication and improve maintainability.
Questions:
Is this the right Idea for the steplog API?
![image](https://github.com/facebook/pyre-check/assets/90656205/9458355c-3306-4ccb-b0b7-c3d9360d07bc)
IF this general Idea is correct. Please take look at the newly created steplog.ml and stepLog.mli file and provide any feedback.
I will then implement the feedback and update the taintAnalysis.ml file and ask for feedback once again!
Pull Request resolved: #876
Reviewed By: tianhan0
Differential Revision: D58945119
Pulled By: arthaud
fbshipit-source-id: 65fcbcbfabce39165ed087880029b726de09ca6c
We currently use the following pattern to log a Pysa analysis step (e.g, call graph builting, type checking, etc.):
For instance: https://github.com/facebook/pyre-check/blob/main/source/interprocedural_analyses/taint/taintAnalysis.ml#L723-L743
It would be better to have a proper API that avoids code duplication:
This is tracked internally by T184908437.
The text was updated successfully, but these errors were encountered: