Add default implementation for Object.create(prototype) #47946
+128
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66485209 |
tsaichien
pushed a commit
to tsaichien/react-native
that referenced
this pull request
Nov 26, 2024
Summary: Add default implementation for `Object.create` with custom parent. This default implementation calls into the global object to get the `Object.create` function, and then calls that function with the prototype. Differential Revision: D66485209
tsaichien
force-pushed
the
export-D66485209
branch
from
6443d6c
to
e648407
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66485209 |
tsaichien
pushed a commit
to tsaichien/react-native
that referenced
this pull request
Nov 26, 2024
Summary: Add default implementation for `Object.create` with custom parent. This default implementation calls into the global object to get the `Object.create` function, and then calls that function with the prototype. Differential Revision: D66485209
tsaichien
force-pushed
the
export-D66485209
branch
from
e648407
to
2fde5d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66485209 |
tsaichien
force-pushed
the
export-D66485209
branch
from
2fde5d7
to
b3ff8ec
Compare
tsaichien
pushed a commit
to tsaichien/react-native
that referenced
this pull request
Nov 27, 2024
Summary: Object creation with custom prototype can currently be done, but it is unnecessarily convoluted. Users have to call into the global object to get the `Object.create` function, then call it with the custom prototype. This diff adds a JSI API for Object.create(prototype) to make it easy for users. Changelog: [Internal] Differential Revision: D66485209
|
This pull request was exported from Phabricator. Differential Revision: D66485209 |
tsaichien
force-pushed
the
export-D66485209
branch
from
b3ff8ec
to
9b21f8e
Compare
tsaichien
pushed a commit
to tsaichien/react-native
that referenced
this pull request
Nov 27, 2024
Summary: Object creation with custom prototype can currently be done, but it is unnecessarily convoluted. Users have to call into the global object to get the `Object.create` function, then call it with the custom prototype. This diff adds a JSI API for Object.create(prototype) to make it easy for users. Changelog: [Internal] Differential Revision: D66485209
|
This pull request was exported from Phabricator. Differential Revision: D66485209 |
added 2 commits
November 27, 2024 16:33
…ject.setPrototypeOf (facebook#47996) Summary: Getting and setting an Object's prototype is convulted. Users have to call into the global object to get the method, then call it. This diff adds a JSI API for Object.getPrototype and Object.setPrototype to make it easy for users. Changelog: [Internal] Differential Revision: D66562549
Summary: Object creation with custom prototype can currently be done, but it is unnecessarily convoluted. Users have to call into the global object to get the `Object.create` function, then call it with the custom prototype. This diff adds a JSI API for Object.create(prototype) to make it easy for users. Changelog: [Internal] Differential Revision: D66485209
tsaichien
pushed a commit
to tsaichien/react-native
that referenced
this pull request
Nov 28, 2024
Summary: Object creation with custom prototype can currently be done, but it is unnecessarily convoluted. Users have to call into the global object to get the `Object.create` function, then call it with the custom prototype. This diff adds a JSI API for Object.create(prototype) to make it easy for users. Changelog: [Internal] Differential Revision: D66485209
tsaichien
force-pushed
the
export-D66485209
branch
from
9b21f8e
to
6c33ede
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66485209 |
tsaichien
force-pushed
the
export-D66485209
branch
from
6c33ede
to
57071c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66485209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add default implementation for
Object.createwith custom parent. Thisdefault implementation calls into the global object to get the
Object.createfunction, and then calls that function with theprototype.
Differential Revision: D66485209