From 639cd8f4250f9394a7c2118003b00eebacf70e31 Mon Sep 17 00:00:00 2001 From: michael faith Date: Sun, 23 Feb 2025 14:56:28 -0600 Subject: [PATCH] test(react-refresh): update snapshots after babel package dedupe --- .../ReactFreshBabelPlugin-test.js.snap | 170 ++---------------- 1 file changed, 16 insertions(+), 154 deletions(-) diff --git a/packages/react-refresh/src/__tests__/__snapshots__/ReactFreshBabelPlugin-test.js.snap b/packages/react-refresh/src/__tests__/__snapshots__/ReactFreshBabelPlugin-test.js.snap index 7b18834ae495f..4f0979100339c 100644 --- a/packages/react-refresh/src/__tests__/__snapshots__/ReactFreshBabelPlugin-test.js.snap +++ b/packages/react-refresh/src/__tests__/__snapshots__/ReactFreshBabelPlugin-test.js.snap @@ -2,62 +2,43 @@ exports[`ReactFreshBabelPlugin can handle implicit arrow returns 1`] = ` var _s = $RefreshSig$(), - _s2 = $RefreshSig$(), - _s3 = $RefreshSig$(), - _s4 = $RefreshSig$(), - _s5 = $RefreshSig$(), - _s6 = $RefreshSig$(); - + _s2 = $RefreshSig$(), + _s3 = $RefreshSig$(), + _s4 = $RefreshSig$(), + _s5 = $RefreshSig$(), + _s6 = $RefreshSig$(); export default _s(() => { _s(); - return useContext(X); }, "useContext{}"); export const Foo = () => { _s2(); - return useContext(X); }; - _s2(Foo, "useContext{}"); - _c = Foo; module.exports = _s3(() => { _s3(); - return useContext(X); }, "useContext{}"); - const Bar = () => { _s4(); - return useContext(X); }; - _s4(Bar, "useContext{}"); - _c2 = Bar; - const Baz = _s5(memo(_c3 = _s5(() => { _s5(); - return useContext(X); }, "useContext{}")), "useContext{}"); - _c4 = Baz; - const Qux = () => { _s6(); - return 0, useContext(X); }; - _s6(Qux, "useContext{}"); - _c5 = Qux; - var _c, _c2, _c3, _c4, _c5; - $RefreshReg$(_c, "Foo"); $RefreshReg$(_c2, "Bar"); $RefreshReg$(_c3, "Baz$memo"); @@ -67,7 +48,6 @@ $RefreshReg$(_c5, "Qux"); exports[`ReactFreshBabelPlugin does not consider require-like methods to be HOCs 1`] = ` const A = require('A'); - const B = foo ? require('X') : require('Y'); const C = requireCond(gk, 'C'); const D = import('D'); @@ -80,19 +60,15 @@ export default function App() { ; } _c = App; - var _c; - $RefreshReg$(_c, "App"); `; exports[`ReactFreshBabelPlugin does not get tripped by IIFEs 1`] = ` while (item) { var _s = $RefreshSig$(); - _s(item => { _s(); - useFoo(); }, "useFoo{}", true)(item); } @@ -100,31 +76,23 @@ while (item) { exports[`ReactFreshBabelPlugin generates signatures for function declarations calling hooks 1`] = ` var _s = $RefreshSig$(); - export default function App() { _s(); - const [foo, setFoo] = useState(0); React.useEffect(() => {}); return

{foo}

; } - _s(App, "useState{[foo, setFoo](0)}\\nuseEffect{}"); - _c = App; - var _c; - $RefreshReg$(_c, "App"); `; exports[`ReactFreshBabelPlugin generates signatures for function expressions calling hooks 1`] = ` var _s = $RefreshSig$(), - _s2 = $RefreshSig$(); - + _s2 = $RefreshSig$(); export const A = _s(React.memo(_c2 = _s(React.forwardRef(_c = _s((props, ref) => { _s(); - const [foo, setFoo] = useState(0); React.useEffect(() => {}); return

{foo}

; @@ -132,29 +100,22 @@ export const A = _s(React.memo(_c2 = _s(React.forwardRef(_c = _s((props, ref) => _c3 = A; export const B = _s2(React.memo(_c5 = _s2(React.forwardRef(_c4 = _s2(function (props, ref) { _s2(); - const [foo, setFoo] = useState(0); React.useEffect(() => {}); return

{foo}

; }, "useState{[foo, setFoo](0)}\\nuseEffect{}")), "useState{[foo, setFoo](0)}\\nuseEffect{}")), "useState{[foo, setFoo](0)}\\nuseEffect{}"); _c6 = B; - function hoc() { var _s3 = $RefreshSig$(); - return _s3(function Inner() { _s3(); - const [foo, setFoo] = useState(0); React.useEffect(() => {}); return

{foo}

; }, "useState{[foo, setFoo](0)}\\nuseEffect{}"); } - export let C = hoc(); - var _c, _c2, _c3, _c4, _c5, _c6; - $RefreshReg$(_c, "A$React.memo$React.forwardRef"); $RefreshReg$(_c2, "A$React.memo"); $RefreshReg$(_c3, "A"); @@ -165,38 +126,28 @@ $RefreshReg$(_c6, "B"); exports[`ReactFreshBabelPlugin generates valid signature for exotic ways to call Hooks 1`] = ` var _s2 = $RefreshSig$(); - import FancyHook from 'fancy'; export default function App() { _s2(); - var _s = $RefreshSig$(); - function useFancyState() { _s(); - const [foo, setFoo] = React.useState(0); useFancyEffect(); return foo; } - _s(useFancyState, "useState{[foo, setFoo](0)}\\nuseFancyEffect{}", true); - const bar = useFancyState(); const baz = FancyHook.useThing(); React.useState(); useThePlatform(); return

{bar}{baz}

; } - _s2(App, "useFancyState{bar}\\nuseThing{baz}\\nuseState{}\\nuseThePlatform{}", true, function () { return [FancyHook.useThing]; }); - _c = App; - var _c; - $RefreshReg$(_c, "App"); `; @@ -204,21 +155,16 @@ exports[`ReactFreshBabelPlugin ignores HOC definitions 1`] = ` let connect = () => { function Comp() { const handleClick = () => {}; - return

Hi

; } - return Comp; }; - function withRouter() { return function Child() { const handleClick = () => {}; - return

Hi

; }; } - ; `; @@ -226,15 +172,12 @@ exports[`ReactFreshBabelPlugin ignores complex definitions 1`] = ` let A = foo ? () => { return

Hi

; } : null; - const B = function Foo() { return

Hi

; }(); - let C = () => () => { return

Hi

; }; - let D = bar && (() => { return

Hi

; }); @@ -244,11 +187,9 @@ exports[`ReactFreshBabelPlugin ignores higher-order functions that are not HOCs const throttledAlert = throttle(function () { alert('Hi'); }); - const TooComplex = function () { return hello; }(() => {}); - if (cond) { const Foo = thing(() => {}); } @@ -258,44 +199,32 @@ exports[`ReactFreshBabelPlugin ignores unnamed function declarations 1`] = `expo exports[`ReactFreshBabelPlugin includes custom hooks into the signatures 1`] = ` var _s = $RefreshSig$(), - _s2 = $RefreshSig$(), - _s3 = $RefreshSig$(); - + _s2 = $RefreshSig$(), + _s3 = $RefreshSig$(); function useFancyState() { _s(); - const [foo, setFoo] = React.useState(0); useFancyEffect(); return foo; } - _s(useFancyState, "useState{[foo, setFoo](0)}\\nuseFancyEffect{}", false, function () { return [useFancyEffect]; }); - const useFancyEffect = () => { _s2(); - React.useEffect(() => {}); }; - _s2(useFancyEffect, "useEffect{}"); - export default function App() { _s3(); - const bar = useFancyState(); return

{bar}

; } - _s3(App, "useFancyState{bar}", false, function () { return [useFancyState]; }); - _c = App; - var _c; - $RefreshReg$(_c, "App"); `; @@ -306,26 +235,18 @@ Object.defineProperty(exports, "__esModule", { value: true }); exports.default = App; - var _hooks = require("./hooks"); - var _s = $RefreshSig$(); - function App() { _s(); - const bar = (0, _hooks.useFancyState)(); return

{bar}

; } - _s(App, "useFancyState{bar}", false, function () { return [_hooks.useFancyState]; }); - _c = App; - var _c; - $RefreshReg$(_c, "App"); `; @@ -339,16 +260,13 @@ exports[`ReactFreshBabelPlugin registers capitalized identifiers in HOC calls 1` function Foo() { return

Hi

; } - _c = Foo; export default _c2 = hoc(Foo); export const A = hoc(Foo); _c3 = A; const B = hoc(Foo); _c4 = B; - var _c, _c2, _c3, _c4; - $RefreshReg$(_c, "Foo"); $RefreshReg$(_c2, "%default%"); $RefreshReg$(_c3, "A"); @@ -375,21 +293,17 @@ const FunnyFactory = funny.factory\`\`; let Alias1 = A; let Alias2 = A.Foo; const Dict = {}; - function Foo() { return
; } - _c5 = Foo; -const B = hoc(A); // This is currently registered as a false positive: - +const B = hoc(A); +// This is currently registered as a false positive: _c6 = B; -const NotAComponent = wow(A); // We could avoid it but it also doesn't hurt. - +const NotAComponent = wow(A); +// We could avoid it but it also doesn't hurt. _c7 = NotAComponent; - var _c, _c2, _c3, _c4, _c5, _c6, _c7; - $RefreshReg$(_c, "Header"); $RefreshReg$(_c2, "StyledFactory1"); $RefreshReg$(_c3, "StyledFactory2"); @@ -419,22 +333,18 @@ const FunnyFactory = funny.factory\`\`; let Alias1 = A; let Alias2 = A.Foo; const Dict = {}; - function Foo() { return [React.createElement(A), React.createElement(B), React.createElement(StyledFactory1), React.createElement(StyledFactory2), React.createElement(StyledFactory3), React.createElement(Alias1), React.createElement(Alias2), jsx(Header), React.createElement(Dict.X)]; } - _c5 = Foo; React.createContext(Store); -const B = hoc(A); // This is currently registered as a false positive: - +const B = hoc(A); +// This is currently registered as a false positive: _c6 = B; -const NotAComponent = wow(A); // We could avoid it but it also doesn't hurt. - +const NotAComponent = wow(A); +// We could avoid it but it also doesn't hurt. _c7 = NotAComponent; - var _c, _c2, _c3, _c4, _c5, _c6, _c7; - $RefreshReg$(_c, "Header"); $RefreshReg$(_c2, "StyledFactory1"); $RefreshReg$(_c3, "StyledFactory2"); @@ -456,9 +366,7 @@ _c5 = B; export default _c8 = React.memo(_c7 = forwardRef(_c6 = (props, ref) => { return

Foo

; })); - var _c, _c2, _c3, _c4, _c5, _c6, _c7, _c8; - $RefreshReg$(_c, "A$forwardRef"); $RefreshReg$(_c2, "A"); $RefreshReg$(_c3, "B$memo$React.forwardRef"); @@ -473,9 +381,7 @@ exports[`ReactFreshBabelPlugin registers likely HOCs with inline functions 2`] = export default _c3 = React.memo(_c2 = forwardRef(_c = function (props, ref) { return

Foo

; })); - var _c, _c2, _c3; - $RefreshReg$(_c, "%default%$React.memo$forwardRef"); $RefreshReg$(_c2, "%default%$React.memo"); $RefreshReg$(_c3, "%default%"); @@ -485,9 +391,7 @@ exports[`ReactFreshBabelPlugin registers likely HOCs with inline functions 3`] = export default _c3 = React.memo(_c2 = forwardRef(_c = function Named(props, ref) { return

Foo

; })); - var _c, _c2, _c3; - $RefreshReg$(_c, "%default%$React.memo$forwardRef"); $RefreshReg$(_c2, "%default%$React.memo"); $RefreshReg$(_c3, "%default%"); @@ -496,7 +400,6 @@ $RefreshReg$(_c3, "%default%"); exports[`ReactFreshBabelPlugin registers top-level exported function declarations 1`] = ` export function Hello() { function handleClick() {} - return

Hi

; } _c = Hello; @@ -504,19 +407,15 @@ export default function Bar() { return ; } _c2 = Bar; - function Baz() { return

OK

; } - _c3 = Baz; const NotAComp = 'hi'; export { Baz, NotAComp }; export function sum() {} export const Bad = 42; - var _c, _c2, _c3; - $RefreshReg$(_c, "Hello"); $RefreshReg$(_c2, "Bar"); $RefreshReg$(_c3, "Baz"); @@ -525,7 +424,6 @@ $RefreshReg$(_c3, "Baz"); exports[`ReactFreshBabelPlugin registers top-level exported named arrow functions 1`] = ` export const Hello = () => { function handleClick() {} - return

Hi

; }; _c = Hello; @@ -536,9 +434,7 @@ export default (() => { // You should name your components. return ; }); - var _c, _c2; - $RefreshReg$(_c, "Hello"); $RefreshReg$(_c2, "Bar"); `; @@ -546,20 +442,14 @@ $RefreshReg$(_c2, "Bar"); exports[`ReactFreshBabelPlugin registers top-level function declarations 1`] = ` function Hello() { function handleClick() {} - return

Hi

; } - _c = Hello; - function Bar() { return ; } - _c2 = Bar; - var _c, _c2; - $RefreshReg$(_c, "Hello"); $RefreshReg$(_c2, "Bar"); `; @@ -567,26 +457,17 @@ $RefreshReg$(_c2, "Bar"); exports[`ReactFreshBabelPlugin registers top-level variable declarations with arrow functions 1`] = ` let Hello = () => { const handleClick = () => {}; - return

Hi

; }; - _c = Hello; - const Bar = () => { return ; }; - _c2 = Bar; - var Baz = () =>
; - _c3 = Baz; - var sum = () => {}; - var _c, _c2, _c3; - $RefreshReg$(_c, "Hello"); $RefreshReg$(_c2, "Bar"); $RefreshReg$(_c3, "Baz"); @@ -595,25 +476,17 @@ $RefreshReg$(_c3, "Baz"); exports[`ReactFreshBabelPlugin registers top-level variable declarations with function expressions 1`] = ` let Hello = function () { function handleClick() {} - return

Hi

; }; - _c = Hello; - const Bar = function Baz() { return ; }; - _c2 = Bar; - function sum() {} - let Baz = 10; var Qux; - var _c, _c2; - $RefreshReg$(_c, "Hello"); $RefreshReg$(_c2, "Bar"); `; @@ -637,9 +510,7 @@ namespace Foo { export const E = () => {}; } } - var _c, _c2, _c3, _c4; - $RefreshReg$(_c, "Foo$Bar$A"); $RefreshReg$(_c2, "Foo$Bar$B"); $RefreshReg$(_c3, "Foo$C"); @@ -648,21 +519,15 @@ $RefreshReg$(_c4, "Foo$D"); exports[`ReactFreshBabelPlugin uses custom identifiers for $RefreshReg$ and $RefreshSig$ 1`] = ` var _s = import.meta.refreshSig(); - export default function Bar() { _s(); - useContext(X); return ; } - _s(Bar, "useContext{}"); - _c = Bar; ; - var _c; - import.meta.refreshReg(_c, "Bar"); `; @@ -670,11 +535,8 @@ exports[`ReactFreshBabelPlugin uses original function declaration if it get reas function Hello() { return

Hi

; } - _c = Hello; Hello = connect(Hello); - var _c; - $RefreshReg$(_c, "Hello"); `;