Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Xcode 8.3 warning #77

Open
Huang-Libo opened this issue Mar 28, 2017 · 3 comments
Open

Xcode 8.3 warning #77

Huang-Libo opened this issue Mar 28, 2017 · 3 comments

Comments

@Huang-Libo
Copy link

Huang-Libo commented Mar 28, 2017

warning info:
Assigning to 'id<CALayerDelegate> _Nullable' from incompatible type 'FBShimmeringLayer *const __strong'

- (void)_createMaskIfNeeded
{
  if (_shimmering && !_maskLayer) {
    _maskLayer = [FBShimmeringMaskLayer layer];
    _maskLayer.delegate = self;     // -> warning here ...
    _contentLayer.mask = _maskLayer;
    [self _updateMaskColors];
    [self _updateMaskLayout];
  }
}
@otymartin
Copy link

@grp @ejensen

@DrBeak1
Copy link

DrBeak1 commented Apr 10, 2017

This can be fixed easily by making the change on line 136 of FBShimmeringLayer.m:

@interface FBShimmeringLayer ()
<CALayerDelegate> // <= right here
@property (strong, nonatomic) FBShimmeringMaskLayer *maskLayer;
@end

@mattbarker016
Copy link

mattbarker016 commented Apr 25, 2017

There's another error in the FBShimmering protocol lines 39-40. Anyone know how to resolve it?

screen shot 2017-04-24 at 11 37 07 pm

Update: I just commented it out ¯_(ツ)_/¯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants