Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Implement Windows support #265

Open
1 task
sunshowers opened this issue Feb 4, 2021 · 2 comments
Open
1 task

Implement Windows support #265

sunshowers opened this issue Feb 4, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@sunshowers
Copy link
Contributor

sunshowers commented Feb 4, 2021

Still TODO:

  • Get cargo-compare running on Windows.

Some of the failures we're seeing are:

thread 'tests::workspace_tests::cargo_guppy::proptest_compare' panicked at 'compute_diff succeeded: failed to read `\\?\D:\a\cargo-guppy\cargo-guppy\internal-tools/benchmarks\Cargo.toml`

Caused by:
    The filename, directory name, or volume label syntax is incorrect. (os error 123)', internal-tools\cargo-compare\src\tests\proptest_helpers.rs:42:10

thread 'tests::workspace_tests::inside_outside::proptest_compare' panicked at 'compute_diff succeeded: package collision in the lockfile: packages external v0.1.0 (D:\a\cargo-guppy\cargo-guppy\fixtures\workspace\inside-outside\external) and external v0.1.0 (D:\a\cargo-guppy\cargo-guppy\fixtures\workspace\inside-outside\workspace\internal-macro\../../external) are different, but only one can be written to lockfile unambiguously', internal-tools\cargo-compare\src\tests\proptest_helpers.rs:42:10
@sunshowers sunshowers added the help wanted Extra attention is needed label Feb 5, 2021
@sunshowers
Copy link
Contributor Author

Tagging this as "help wanted" -- I don't really use or target Windows for development so it would be good to have experienced Windows developers fix up any remaining issues.

@sunshowers
Copy link
Contributor Author

We can probably address this by switching out cargo-compare to use the new cargo tree support for printing out resolved features.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant