Disambiguate PHP shortform ternary #100
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I realize this is a PR for an issue that was brought up over a year ago but I am using this as a trial 🎈 to better understand the code base. I was hoping for comments and feedback so I can begin digging into some larger issues. Thanks! |
|
@jeffrafter @aryx It's been a while. Should we merge this? |
|
Can you rebase on a more recent version. Apparently we can't automatically merge your request. |
|
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
This should fix #56
The current PHP parsing did not support short from ternary (
?:) with an immediate token such astrueorfalsefollowing it. I copied the ruleset from https://github.com/facebook/hhvm/blob/master/hphp/parser/hphp.ll#L515 (except for the maybe states) and tried to implement a better lookahead.I am not sure I did this in the correct/most efficient way and welcome comments/suggestions.