Skip to content
This repository was archived by the owner on Jan 1, 2025. It is now read-only.

Commit 532afa3

Browse files
mrochmroch
authored
Daily removal of unused Flow suppressions
Differential Revision: D45081285 Pull Request resolved: #2220
1 parent 7ecd6f8 commit 532afa3

30 files changed

+7
-213
lines changed

‎packages/recoil-relay/RecoilRelay_graphQLSelectorFamily.js

-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ function graphQLSelectorFamily<
115115
variables: vars,
116116
// $FlowIssue[incompatible-call] Type is opaque, no way to refine
117117
subscription: query,
118-
// $FlowFixMe[missing-local-annot]
119118
mapResponse: response => ({source: 'remote', response}),
120119
}),
121120
mutations &&

‎packages/recoil-sync/RecoilSync.js

-1
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,6 @@ function readAtomItems<T>(
222222
: readFromStorageRequired(itemKey);
223223

224224
if (RecoilLoadable.isLoadable(value)) {
225-
// $FlowIssue[incompatible-type]
226225
const loadable: Loadable<mixed> = value;
227226
if (loadable.state === 'hasError') {
228227
throw loadable.contents;

‎packages/recoil-sync/__tests__/RecoilSync_URLCompound-test.js

-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ testRecoil('Many items to one atom', async () => {
104104
return;
105105
}
106106
for (const key of Object.keys(newValue)) {
107-
// $FlowFixMe[prop-missing]
108107
write(key, newValue[key]);
109108
}
110109
},

‎packages/recoil/adt/Recoil_Loadable.js

-1
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,6 @@ class LoadingLoadable<T> extends BaseLoadable<T> {
180180
return nextLoadable.contents;
181181
}
182182
}
183-
// $FlowIssue[incompatible-return]
184183
return next;
185184
})
186185
// $FlowFixMe[incompatible-call]

‎packages/recoil/core/__tests__/Recoil_RecoilRoot-test.js

-3
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,10 @@ describe('initializeState', () => {
8282
key: 'RecoilRoot - initializeState - selector',
8383
default: 'DEFAULT',
8484
});
85-
// $FlowFixMe[incompatible-call]
8685
const mySelector = selector({
8786
key: 'RecoilRoot - initializeState - selector selector',
8887
// $FlowFixMe[missing-local-annot]
8988
get: ({get}) => get(myAtom),
90-
// $FlowFixMe[incompatible-call]
9189
// $FlowFixMe[missing-local-annot]
9290
set: ({set}, newValue) => set(myAtom, newValue),
9391
});
@@ -207,7 +205,6 @@ describe('initializeState', () => {
207205
'Selectors from global initialization are not canceled',
208206
async () => {
209207
const [asyncSel, resolve] = asyncSelector<string, _>();
210-
// $FlowFixMe[incompatible-call]
211208
const depSel = selector({
212209
key: 'RecoilRoot - initializeSTate - async selector',
213210
// $FlowFixMe[missing-local-annot]

‎packages/recoil/core/__tests__/Recoil_RecoilValueInterface-test.js

-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ const testRecoil = getRecoilTestFn(() => {
5757

5858
dependsOnDependsOnA = selector({
5959
key: 'dependsOnDependsOnA',
60-
// $FlowFixMe[unsafe-addition]
6160
// $FlowFixMe[missing-local-annot]
6261
get: ({get}) => get(dependsOnA) + 1,
6362
});

‎packages/recoil/core/__tests__/Recoil_Retention-test.js

-5
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ describe('Retention of and via selectors', () => {
220220
return;
221221
}
222222
const anAtom = atomRetainedBy('components');
223-
// $FlowFixMe[incompatible-call]
224223
const aSelector = selector({
225224
key: '...',
226225
retainedBy_UNSTABLE: 'components',
@@ -270,7 +269,6 @@ describe('Retention of and via selectors', () => {
270269
const c = renderElements(<SubscribesToSelector />);
271270
expect(c.textContent).toEqual('loading');
272271
expect(evalCount).toBe(1);
273-
// $FlowFixMe[incompatible-call]
274272
act(() => resolve(123));
275273
// We need to let the selector promise resolve but NOT flush timeouts because
276274
// we do release after suspending after a timeout and we don't want that
@@ -321,13 +319,11 @@ describe('Retention of and via selectors', () => {
321319
expect(c.textContent).toEqual('loading');
322320
expect(evalCount).toBe(1);
323321
act(() => setMounted(false)); // release selector while promise is in flight
324-
// $FlowFixMe[incompatible-call]
325322
act(() => resolve(123));
326323
await flushPromises();
327324
act(() => setMounted(true));
328325
expect(evalCount).toBe(2); // selector must be re-evaluated because the resolved value is not in cache
329326
expect(c.textContent).toEqual('loading');
330-
// $FlowFixMe[incompatible-call]
331327
act(() => resolve(123));
332328
await flushPromises();
333329
expect(c.textContent).toEqual('123');
@@ -347,7 +343,6 @@ describe('Retention of and via selectors', () => {
347343
});
348344
const depA = atomRetainedBy('components');
349345
const depB = atomRetainedBy('components');
350-
// $FlowFixMe[incompatible-call]
351346
const theSelector = selector({
352347
key: 'sel',
353348
// $FlowFixMe[missing-local-annot]

‎packages/recoil/core/__tests__/Recoil_Snapshot-test.js

-14
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ testRecoil('getNodes', () => {
8989
expect(snapshot.getLoadable(nodesAfterGet[0]).contents).toEqual('DEFAULT');
9090

9191
// Test selectors
92-
// $FlowFixMe[incompatible-call]
9392
const mySelector = selector({
9493
key: 'snapshot getNodes selector',
9594
// $FlowFixMe[missing-local-annot]
@@ -359,7 +358,6 @@ testRecoil('getInfo', () => {
359358
key: 'snapshot getInfo atom',
360359
default: 'DEFAULT',
361360
});
362-
// $FlowFixMe[incompatible-call]
363361
const selectorA = selector({
364362
key: 'getInfo A',
365363
// $FlowFixMe[missing-local-annot]
@@ -392,17 +390,14 @@ testRecoil('getInfo', () => {
392390
expect(Array.from(getInfo(snapshot, selectorA).subscribers.nodes)).toEqual(
393391
[],
394392
);
395-
// $FlowFixMe[incompatible-call]
396393
expect(getInfo(snapshot, selectorB)).toMatchObject({
397394
loadable: undefined,
398395
isActive: false,
399396
isSet: false,
400397
isModified: false,
401398
type: 'selector',
402399
});
403-
// $FlowFixMe[incompatible-call]
404400
expect(Array.from(getInfo(snapshot, selectorB).deps)).toEqual([]);
405-
// $FlowFixMe[incompatible-call]
406401
expect(Array.from(getInfo(snapshot, selectorB).subscribers.nodes)).toEqual(
407402
[],
408403
);
@@ -433,7 +428,6 @@ testRecoil('getInfo', () => {
433428
expect(Array.from(getInfo(snapshot, selectorA).subscribers.nodes)).toEqual(
434429
expect.arrayContaining([selectorB]),
435430
);
436-
// $FlowFixMe[incompatible-call]
437431
expect(getInfo(snapshot, selectorB)).toMatchObject({
438432
loadable: expect.objectContaining({
439433
state: 'hasValue',
@@ -444,11 +438,9 @@ testRecoil('getInfo', () => {
444438
isModified: false,
445439
type: 'selector',
446440
});
447-
// $FlowFixMe[incompatible-call]
448441
expect(Array.from(getInfo(snapshot, selectorB).deps)).toEqual(
449442
expect.arrayContaining([myAtom, selectorA]),
450443
);
451-
// $FlowFixMe[incompatible-call]
452444
expect(Array.from(getInfo(snapshot, selectorB).subscribers.nodes)).toEqual(
453445
[],
454446
);
@@ -480,19 +472,16 @@ testRecoil('getInfo', () => {
480472
expect(Array.from(getInfo(setSnapshot, selectorA).subscribers.nodes)).toEqual(
481473
expect.arrayContaining([selectorB]),
482474
);
483-
// $FlowFixMe[incompatible-call]
484475
expect(getInfo(setSnapshot, selectorB)).toMatchObject({
485476
loadable: expect.objectContaining({state: 'hasValue', contents: 'SETSET'}),
486477
isActive: true,
487478
isSet: false,
488479
isModified: false,
489480
type: 'selector',
490481
});
491-
// $FlowFixMe[incompatible-call]
492482
expect(Array.from(getInfo(setSnapshot, selectorB).deps)).toEqual(
493483
expect.arrayContaining([myAtom, selectorA]),
494484
);
495-
// $FlowFixMe[incompatible-call]
496485
expect(Array.from(getInfo(setSnapshot, selectorB).subscribers.nodes)).toEqual(
497486
[],
498487
);
@@ -524,7 +513,6 @@ testRecoil('getInfo', () => {
524513
expect(
525514
Array.from(getInfo(resetSnapshot, selectorA).subscribers.nodes),
526515
).toEqual(expect.arrayContaining([selectorB]));
527-
// $FlowFixMe[incompatible-call]
528516
expect(getInfo(resetSnapshot, selectorB)).toMatchObject({
529517
loadable: expect.objectContaining({
530518
state: 'hasValue',
@@ -535,12 +523,10 @@ testRecoil('getInfo', () => {
535523
isModified: false,
536524
type: 'selector',
537525
});
538-
// $FlowFixMe[incompatible-call]
539526
expect(Array.from(getInfo(resetSnapshot, selectorB).deps)).toEqual(
540527
expect.arrayContaining([myAtom, selectorA]),
541528
);
542529
expect(
543-
// $FlowFixMe[incompatible-call]
544530
Array.from(getInfo(resetSnapshot, selectorB).subscribers.nodes),
545531
).toEqual([]);
546532
});

‎packages/recoil/core/__tests__/Recoil_perf-test.js

-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ function createAtoms(num: number): Array<RecoilState<string>> {
7777
}
7878

7979
const helpersSelector = () =>
80-
// $FlowFixMe[incompatible-call]
8180
selector({
8281
key: `PERF-helpers-${nextAtomKey++}`,
8382
// $FlowFixMe[missing-local-annot]

‎packages/recoil/hooks/__tests__/Recoil_Hooks_TRANSITION_SUPPORT_UNSTABLE-test.js

-2
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,9 @@ testRecoil('useRecoilState_TRANSITION_SUPPORT_UNSTABLE', async () => {
117117
}
118118
const myAtom = stringAtom();
119119
const [myAsyncSelector, resolve] = asyncSelector<string, _>();
120-
// $FlowFixMe[incompatible-call]
121120
const mySelector = selector({
122121
key: 'useRecoilState_TRANSITION_SUPPORT_UNSTABLE selector',
123122
get: () => myAsyncSelector,
124-
// $FlowFixMe[incompatible-call]
125123
// $FlowFixMe[missing-local-annot]
126124
set: ({set}, newValue) => set(myAtom, newValue),
127125
});

‎packages/recoil/hooks/__tests__/Recoil_PublicHooks-test.js

-4
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ function plusOneAsyncSelector(
109109
get: ({get}) => fn(get(dep)),
110110
});
111111
return [
112-
// $FlowFixMe[incompatible-return]
113112
sel,
114113
x => {
115114
nextTimeoutAmount = x;
@@ -266,7 +265,6 @@ describe('Render counts', () => {
266265
const anAtom = counterAtom();
267266
const [aSelector, _] = plusOneSelector(anAtom);
268267
const [WriteComp, updateValue] = componentThatWritesAtom(anAtom);
269-
// $FlowFixMe[incompatible-call]
270268
const ReadComp = componentThatReadsTwoAtoms(anAtom, aSelector);
271269
renderElements(
272270
<>
@@ -292,7 +290,6 @@ describe('Render counts', () => {
292290
const [ComponentA, updateValueA] = componentThatWritesAtom(atomA);
293291
const [ComponentB, updateValueB] = componentThatWritesAtom(atomB);
294292
const [ReadComp, commit] =
295-
// $FlowFixMe[incompatible-call]
296293
componentThatReadsAtomWithCommitCount(aSelector);
297294
renderElements(
298295
<>
@@ -677,7 +674,6 @@ describe('Component Subscriptions', () => {
677674
() => {
678675
const anAtom = counterAtom();
679676
const [aSelector, _selFn] = plusOneSelector(anAtom);
680-
// $FlowFixMe[incompatible-call]
681677
const [_asyncSel, _adjustTimeout] = plusOneAsyncSelector(aSelector);
682678
// FIXME to implement
683679
},

‎packages/recoil/hooks/__tests__/Recoil_useGetRecoilValueInfo-test.js

-17
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ testRecoil('useGetRecoilValueInfo', ({gks}) => {
4343
key: 'useGetRecoilValueInfo atom',
4444
default: 'DEFAULT',
4545
});
46-
// $FlowFixMe[incompatible-call]
4746
const selectorA = selector({
4847
key: 'useGetRecoilValueInfo A',
4948
// $FlowFixMe[missing-local-annot]
@@ -98,20 +97,16 @@ testRecoil('useGetRecoilValueInfo', ({gks}) => {
9897
[],
9998
);
10099
}
101-
// $FlowFixMe[incompatible-call]
102100
expect(getNodeInfo(selectorB)).toMatchObject({
103101
loadable: undefined,
104102
isActive: false,
105103
isSet: false,
106104
isModified: false,
107105
type: 'selector',
108106
});
109-
// $FlowFixMe[incompatible-call]
110107
expect(Array.from(getNodeInfo(selectorB).deps)).toEqual([]);
111-
// $FlowFixMe[incompatible-call]
112108
expect(Array.from(getNodeInfo(selectorB).subscribers.nodes)).toEqual([]);
113109
if (gks.includes('recoil_infer_component_names')) {
114-
// $FlowFixMe[incompatible-call]
115110
expect(Array.from(getNodeInfo(selectorB).subscribers.components)).toEqual(
116111
[],
117112
);
@@ -169,7 +164,6 @@ testRecoil('useGetRecoilValueInfo', ({gks}) => {
169164
[],
170165
);
171166
}
172-
// $FlowFixMe[incompatible-call]
173167
expect(getNodeInfo(selectorB)).toMatchObject({
174168
loadable: expect.objectContaining({
175169
state: 'hasValue',
@@ -180,14 +174,11 @@ testRecoil('useGetRecoilValueInfo', ({gks}) => {
180174
isModified: false,
181175
type: 'selector',
182176
});
183-
// $FlowFixMe[incompatible-call]
184177
expect(Array.from(getNodeInfo(selectorB).deps)).toEqual(
185178
expect.arrayContaining([myAtom, selectorA]),
186179
);
187-
// $FlowFixMe[incompatible-call]
188180
expect(Array.from(getNodeInfo(selectorB).subscribers.nodes)).toEqual([]);
189181
if (gks.includes('recoil_infer_component_names')) {
190-
// $FlowFixMe[incompatible-call]
191182
expect(Array.from(getNodeInfo(selectorB).subscribers.components)).toEqual([
192183
{name: 'ReadsAtom'},
193184
]);
@@ -230,7 +221,6 @@ testRecoil('useGetRecoilValueInfo', ({gks}) => {
230221
[],
231222
);
232223
}
233-
// $FlowFixMe[incompatible-call]
234224
expect(getNodeInfo(selectorB)).toMatchObject({
235225
loadable: expect.objectContaining({
236226
state: 'hasValue',
@@ -241,14 +231,11 @@ testRecoil('useGetRecoilValueInfo', ({gks}) => {
241231
isModified: false,
242232
type: 'selector',
243233
});
244-
// $FlowFixMe[incompatible-call]
245234
expect(Array.from(getNodeInfo(selectorB).deps)).toEqual(
246235
expect.arrayContaining([myAtom, selectorA]),
247236
);
248-
// $FlowFixMe[incompatible-call]
249237
expect(Array.from(getNodeInfo(selectorB).subscribers.nodes)).toEqual([]);
250238
if (gks.includes('recoil_infer_component_names')) {
251-
// $FlowFixMe[incompatible-call]
252239
expect(Array.from(getNodeInfo(selectorB).subscribers.components)).toEqual([
253240
{name: 'ReadsAtom'},
254241
]);
@@ -297,7 +284,6 @@ testRecoil('useGetRecoilValueInfo', ({gks}) => {
297284
[],
298285
);
299286
}
300-
// $FlowFixMe[incompatible-call]
301287
expect(getNodeInfo(selectorB)).toMatchObject({
302288
loadable: expect.objectContaining({
303289
state: 'hasValue',
@@ -308,14 +294,11 @@ testRecoil('useGetRecoilValueInfo', ({gks}) => {
308294
isModified: false,
309295
type: 'selector',
310296
});
311-
// $FlowFixMe[incompatible-call]
312297
expect(Array.from(getNodeInfo(selectorB).deps)).toEqual(
313298
expect.arrayContaining([myAtom, selectorA]),
314299
);
315-
// $FlowFixMe[incompatible-call]
316300
expect(Array.from(getNodeInfo(selectorB).subscribers.nodes)).toEqual([]);
317301
if (gks.includes('recoil_infer_component_names')) {
318-
// $FlowFixMe[incompatible-call]
319302
expect(Array.from(getNodeInfo(selectorB).subscribers.components)).toEqual([
320303
{name: 'ReadsAtom'},
321304
]);

‎packages/recoil/hooks/__tests__/Recoil_useGotoRecoilSnapshot-test.js

-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ testRecoil('Goto snapshot with dependent async selector', async () => {
150150
default: 'DEFAULT',
151151
});
152152
const [ReadsAndWritesAtom, setAtom] = componentThatReadsAndWritesAtom(myAtom);
153-
// $FlowFixMe[incompatible-call]
154153
const mySelector = selector({
155154
key: 'selector for async snapshot',
156155
// $FlowFixMe[missing-local-annot]

‎packages/recoil/hooks/__tests__/Recoil_useRecoilCallback-test.js

-3
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,6 @@ describe('Selector Cache', () => {
607607
});
608608

609609
let i = 0;
610-
// $FlowFixMe[incompatible-call]
611610
const myselector = selector({
612611
key: 'useRecoilCallback refresh entire cache selector',
613612
// $FlowFixMe[missing-local-annot]
@@ -648,7 +647,6 @@ describe('Snapshot', () => {
648647
resolveCallback;
649648

650649
const myAtom = stringAtom();
651-
// $FlowFixMe[incompatible-call]
652650
const mySelector1 = selector({
653651
key: 'useRecoilCallback snapshot retain 1',
654652
// $FlowFixMe[missing-local-annot]
@@ -659,7 +657,6 @@ describe('Snapshot', () => {
659657
return get(myAtom);
660658
},
661659
});
662-
// $FlowFixMe[incompatible-call]
663660
const mySelector2 = selector({
664661
key: 'useRecoilCallback snapshot retain 2',
665662
// $FlowFixMe[missing-local-annot]

‎packages/recoil/hooks/__tests__/Recoil_useRecoilRefresher-test.js

-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ testRecoil('useRecoilRefresher - clears entire cache', async () => {
7979
});
8080

8181
let i = 0;
82-
// $FlowFixMe[incompatible-call]
8382
const myselector = selector({
8483
key: 'useRecoilRefresher entire cache selector',
8584
// $FlowFixMe[missing-local-annot]

‎packages/recoil/hooks/__tests__/Recoil_useRecoilSnapshot-test.js

-1
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,6 @@ testRecoil('Subscriptions', async () => {
228228
key: 'useRecoilSnapshot Subscriptions atom',
229229
default: 'ATOM',
230230
});
231-
// $FlowFixMe[incompatible-call]
232231
const selectorA = selector({
233232
key: 'useRecoilSnapshot Subscriptions A',
234233
// $FlowFixMe[missing-local-annot]

0 commit comments

Comments
 (0)