build: Removed GTest::gtest_main from CMakeLists.txt for velox_simple_aggregate_test #11668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
assignUser
changed the title
assignUser
reviewed
Nov 27, 2024
minhancao
force-pushed
the
remove_gtest_main_for_velox_simple_aggregate_test
branch
from
84664ee to
eece5ba
Compare
zuyu
reviewed
Nov 27, 2024
minhancao
force-pushed
the
remove_gtest_main_for_velox_simple_aggregate_test
branch
from
eece5ba to
e2b4375
Compare
assignUser
added
the
ready-to-merge
|
|
minhancao
force-pushed
the
remove_gtest_main_for_velox_simple_aggregate_test
branch
from
e2b4375 to
bc05309
Compare
…velox_simple_aggregate_test
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 4dd6499. |
TongWei1105
pushed a commit
to TongWei1105/velox
that referenced
this pull request
Dec 21, 2024
…_aggregate_test (facebookincubator#11668) Summary: Removed GTest::gtest_main from CMakeLists.txt for velox_simple_aggregate_test. ``` add_executable(velox_simple_aggregate_test SimpleAggregateAdapterTest.cpp Main.cpp) ``` Since Main.cpp is already included here, GTest::gtest_main is not needed in target_link_libraries. Pull Request resolved: facebookincubator#11668 Reviewed By: kagamiori Differential Revision: D66690701 Pulled By: xiaoxmeng fbshipit-source-id: 51c5536de45bfd15abdf7a83f46c95f09846a976
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…_aggregate_test (facebookincubator#11668) Summary: Removed GTest::gtest_main from CMakeLists.txt for velox_simple_aggregate_test. ``` add_executable(velox_simple_aggregate_test SimpleAggregateAdapterTest.cpp Main.cpp) ``` Since Main.cpp is already included here, GTest::gtest_main is not needed in target_link_libraries. Pull Request resolved: facebookincubator#11668 Reviewed By: kagamiori Differential Revision: D66690701 Pulled By: xiaoxmeng fbshipit-source-id: 51c5536de45bfd15abdf7a83f46c95f09846a976
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed GTest::gtest_main from CMakeLists.txt for velox_simple_aggregate_test.
Since Main.cpp is already included here, GTest::gtest_main is not needed in target_link_libraries.