Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

fix typo (maybe) for ipython notebook demo #249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

steins024
Copy link

what

Fix a small bug for ipython notebook demo

why

Apply bpe failed, source file not exist, maybe a typo

In the code several lines below, it consumes "/tmp/sentences" as source file

applybpe /tmp/sentences.bpe /tmp/sentences

But here it write sentences into "/tmp/sentences.bpe"

with open('/tmp/sentences.bpe', 'w') as fwrite:

change:

Write sentences into "/tmp/sentences":

with open('/tmp/sentences', 'w') as fwrite:

@facebook-github-bot
Copy link

Hi steins024! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 27, 2019
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@giove91 giove91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants