Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Python Reference Code for Animations et al. #50

Open
thomasnield opened this issue Apr 5, 2022 · 2 comments
Open

Python Reference Code for Animations et al. #50

thomasnield opened this issue Apr 5, 2022 · 2 comments

Comments

@thomasnield
Copy link
Contributor

As discussed, there are Python code files used to generate MP4 files containing animations and simulations to support the tutorial notebooks. I have been putting them here with the same generated name as their generated MP4 counterparts.

https://github.com/facebookresearch/diffkt/tree/main/tutorials/resources

These animations were built using Manim which is an effective Python library to generate 2D and 3D visualizations and simulations. On a handful of examples I have used JAX paired with Manim.

As Neal said, it's probably not in our interest to have JAX or Python source code in a Kotlin project, as it would marginalize both DiffKt and Kotlin. Creating a visualization library similar to Manim would be ideal in my opinion, but as Dhavide expressed this would drift away from our immediate objectives significantly.

Some possible solutions to get this out the door:

  • Publish only the MP4 artifacts and archive the Python files privately
  • Re-implement visualizations to a JVM-based solution (e.g. openrndr)
  • Remove visualizations altogether
@david-boney-jobs
Copy link
Contributor

I think you should keep the mp4 files but privately archive the python code.

@thomasnield
Copy link
Contributor Author

@dboney-openteams yeah I started to take that policy and have already been removing the python files. I'll sweep and do a separate PR if there are any left.

@gafter gafter transferred this issue from another repository May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants