PR review feedback implementation

facebookresearch · Apr 8, 2021 · a9764f1 · a9764f1
1 parent 5fdea84
commit a9764f1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/vissl/trainer/trainer_main.py b/vissl/trainer/trainer_main.py
@@ -187,7 +187,8 @@ def train(self):
                         logging.info("CUDA cache cleared")
                     task = train_step_fn(task)
                     iteration_num += 1
-                    task.local_iteration_num = task.event_storage.iter = iteration_num
+                    task.local_iteration_num = iteration_num
+                    task.event_storage.iter = iteration_num
                     task.run_hooks(SSLClassyHookFunctions.on_step.name)
                 except StopIteration:
                     break

diff --git a/vissl/utils/io.py b/vissl/utils/io.py
@@ -62,7 +62,7 @@ def save_file(data, filename):
         with PathManager.open(filename, "wb") as fopen:
             np.save(fopen, data)
     elif file_ext == ".json":
-        with PathManager.open(filename, "a") as fopen:
+        with PathManager.open(filename, "w") as fopen:
             fopen.write(json.dumps(data, sort_keys=True) + "\n")
             fopen.flush()
     else: