Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fp-ts #89

Open
pierroberto opened this issue Nov 7, 2024 · 0 comments
Open

Update fp-ts #89

pierroberto opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@pierroberto
Copy link
Collaborator

fp-ts introduced a breaking change in version 2.13.

fortepiano currently relies on version 2.12.1. Updating fortepiano to fp-ts version 2.13 or above causes some tests to fail.

For example:

Mock › Chain › chain › should transform Mock value and chain the result

    TypeError: f is not a function

      664 |
      665 |       it('should transform Mock value and chain the result', () => {
    > 666 |         const x = M()()
          |                   ^
      667 |
      668 |         expect(x.email).toBe(
      669 |           `${x.firstName}.${x.lastName}@pulp.com`.toLowerCase(),

      at node_modules/fp-ts/lib/IO.js:48:59
      at node_modules/fp-ts/lib/IO.js:50:63
      at node_modules/fp-ts/lib/IO.js:48:61
      at node_modules/fp-ts/lib/IO.js:50:63
      at Object.<anonymous> (src/Mock.test.ts:666:19)

This issue seems to stem from deprecated methods, such as flip in function module. Updating this module should allow fortepiano to be compatible with the latest version of fp-ts (currently 2.16.5).

@pierroberto pierroberto added the dependencies Pull requests that update a dependency file label Nov 7, 2024
@pierroberto pierroberto self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant