From ef7657e9879357f05d61b6c8a847fc46185efce0 Mon Sep 17 00:00:00 2001 From: Alessandro Lai Date: Tue, 12 Dec 2023 07:14:40 +0100 Subject: [PATCH 1/4] Test against PHP 8.3 (#136) --- .github/workflows/ci.yaml | 3 +++ tests/Unit/DataCollector/MongoDbDataCollectorTest.php | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e08fb98..0bc3de6 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -36,6 +36,9 @@ jobs: - php: 8.2 mongo-ext: 1.15.0 mongo-img: 6.0 + - php: 8.3 + mongo-ext: 1.16.0 + mongo-img: 6.0 steps: - name: Checkout diff --git a/tests/Unit/DataCollector/MongoDbDataCollectorTest.php b/tests/Unit/DataCollector/MongoDbDataCollectorTest.php index 9e52cfa..4d47486 100644 --- a/tests/Unit/DataCollector/MongoDbDataCollectorTest.php +++ b/tests/Unit/DataCollector/MongoDbDataCollectorTest.php @@ -20,7 +20,7 @@ public function test_construction_logger(): void $logEvent = new Query(); $logEvent->setData( [ - 'data' => new BSONDocument(['test']), + 'data' => new BSONDocument(['test' => 'test']), 'date' => $this->getUtcDateTime(), ] ); From 4bbb2f647f2b99d1ad5055ed655686421f5d1226 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 20 Dec 2023 08:46:52 +0100 Subject: [PATCH 2/4] Update phpstan/phpstan requirement from 1.10.41 to 1.10.50 (#141) Updates the requirements on [phpstan/phpstan](https://github.com/phpstan/phpstan) to permit the latest version. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md) - [Commits](https://github.com/phpstan/phpstan/compare/1.10.41...1.10.50) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index ea22582..b3d8b2a 100644 --- a/composer.json +++ b/composer.json @@ -31,7 +31,7 @@ "phpunit/phpunit": "^9.6.13", "symfony/phpunit-bridge": "^6.0", "facile-it/facile-coding-standard": "^0.4.0", - "phpstan/phpstan": "1.10.41", + "phpstan/phpstan": "1.10.50", "phpstan/extension-installer": "1.3.1", "jangregor/phpstan-prophecy": "1.0.0", "phpspec/prophecy": "^1.17", From 427aa145e4a6fa44f0055a6e57c1a65a0ea5c117 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 20 Dec 2023 09:07:35 +0100 Subject: [PATCH 3/4] Update symfony/phpunit-bridge requirement from ^6.0 to ^7.0 (#137) Updates the requirements on [symfony/phpunit-bridge](https://github.com/symfony/phpunit-bridge) to permit the latest version. - [Release notes](https://github.com/symfony/phpunit-bridge/releases) - [Changelog](https://github.com/symfony/phpunit-bridge/blob/6.3/CHANGELOG.md) - [Commits](https://github.com/symfony/phpunit-bridge/compare/v6.0.0...v7.0.1) --- updated-dependencies: - dependency-name: symfony/phpunit-bridge dependency-type: direct:development ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index b3d8b2a..e14585b 100644 --- a/composer.json +++ b/composer.json @@ -29,7 +29,7 @@ "symfony/web-profiler-bundle": "^3.4 || ^4.3 || ^5.0 || ^6.0", "symfony/console": "^3.4 || ^4.3 || ^5.0 || ^6.0", "phpunit/phpunit": "^9.6.13", - "symfony/phpunit-bridge": "^6.0", + "symfony/phpunit-bridge": "^7.0", "facile-it/facile-coding-standard": "^0.4.0", "phpstan/phpstan": "1.10.50", "phpstan/extension-installer": "1.3.1", From 0161ad770ca30d049e275253f44bf2c217ee9826 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 22 Dec 2023 10:12:07 +0100 Subject: [PATCH 4/4] Update facile-it/facile-coding-standard requirement from ^0.4.0 to ^1.0.1 (#138) * Update facile-it/facile-coding-standard requirement Updates the requirements on [facile-it/facile-coding-standard](https://github.com/facile-it/facile-coding-standard) to permit the latest version. - [Release notes](https://github.com/facile-it/facile-coding-standard/releases) - [Changelog](https://github.com/facile-it/facile-coding-standard/blob/1.x/CHANGELOG.md) - [Commits](https://github.com/facile-it/facile-coding-standard/compare/0.4.0...1.0.1) --- updated-dependencies: - dependency-name: facile-it/facile-coding-standard dependency-type: direct:development ... Signed-off-by: dependabot[bot] * Refactor config to work with PHP-CS-Fixer 3 * Apply CS fixes due to new CS rules * Fix PHPStan error --------- Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alessandro Lai --- .gitignore | 2 + .php_cs.dist => .php-cs-fixer.dist.php | 14 ++++-- .php-cs.php | 24 --------- composer.json | 6 +-- phpstan-baseline.neon | 5 -- src/Capsule/Client.php | 8 +-- src/Capsule/Collection.php | 50 +++++-------------- src/Capsule/Database.php | 10 +--- src/Command/AbstractCommand.php | 6 +-- src/Command/DropCollectionCommand.php | 7 +-- src/Command/DropDatabaseCommand.php | 7 +-- src/Command/LoadFixturesCommand.php | 7 +-- src/Controller/ProfilerController.php | 11 ++-- src/DataCollector/MongoDbDataCollector.php | 20 ++------ src/DataCollector/MongoQuerySerializer.php | 5 -- src/DependencyInjection/Configuration.php | 2 +- src/Event/ConnectionEvent.php | 8 +-- src/Event/Listener/DataCollectorListener.php | 11 ---- src/Event/QueryEvent.php | 13 +---- .../AbstractContainerAwareFixture.php | 9 ---- src/Fixtures/MongoFixturesLoader.php | 15 +----- src/Fixtures/OrderedFixtureInterface.php | 2 +- src/Models/ClientConfiguration.php | 30 ----------- src/Models/Query.php | 45 ----------------- src/Services/ClientRegistry.php | 13 ----- src/Services/ConnectionFactory.php | 11 ---- .../DriverOptions/DriverOptionsInterface.php | 2 +- .../Explain/ExplainCommandBuilder.php | 29 ----------- src/Services/Explain/ExplainQueryService.php | 13 ++--- .../Loggers/DataCollectorLoggerInterface.php | 15 ------ src/Services/Loggers/MongoQueryLogger.php | 12 ----- tests/Fixtures/DataFixtures/TestFixtures.php | 7 +-- .../DataFixtures/TestOrderedMongoFixtures.php | 4 +- .../TestOrderedMongoFixtures1.php | 4 +- .../TestOrderedMongoFixtures2.php | 7 +-- tests/Functional/AppTestCase.php | 9 ---- tests/Functional/Capsule/CollectionTest.php | 3 -- .../MongoDbBundleExtensionTest.php | 4 +- tests/Functional/TestApp/TestKernel.php | 4 +- .../MongoQuerySerializerTest.php | 2 - tests/Unit/Fixtures/FixtureSorterTest.php | 20 +++----- tests/Unit/Models/ClientConfigurationTest.php | 3 -- .../Explain/ExplainCommandBuilderTest.php | 6 --- .../Twig/FacileMongoDbBundleExtensionTest.php | 7 --- 44 files changed, 74 insertions(+), 418 deletions(-) rename .php_cs.dist => .php-cs-fixer.dist.php (74%) delete mode 100644 .php-cs.php diff --git a/.gitignore b/.gitignore index 9dbfafe..b9bed70 100644 --- a/.gitignore +++ b/.gitignore @@ -5,6 +5,8 @@ /vendor/ /bin/ .php_cs.cache +/.php-cs-fixer.php +/.php-cs-fixer.cache docker-compose.override.yml .phpunit.result.cache auth.json diff --git a/.php_cs.dist b/.php-cs-fixer.dist.php similarity index 74% rename from .php_cs.dist rename to .php-cs-fixer.dist.php index bad2e89..1f9fc77 100644 --- a/.php_cs.dist +++ b/.php-cs-fixer.dist.php @@ -4,15 +4,21 @@ * Additional rules or rules to override. * These rules will be added to default rules or will override them if the same key already exists. */ - -$additionalRules = []; + +$additionalRules = [ + 'blank_line_after_opening_tag' => false, +]; + $rulesProvider = new Facile\CodingStandards\Rules\CompositeRulesProvider([ new Facile\CodingStandards\Rules\DefaultRulesProvider(), new Facile\CodingStandards\Rules\ArrayRulesProvider($additionalRules), ]); -$config = PhpCsFixer\Config::create(); -$config->setRules($rulesProvider->getRules()); +$config = new PhpCsFixer\Config(); +$config + ->setUsingCache(true) + ->setRiskyAllowed(true) + ->setRules($rulesProvider->getRules()); $finder = PhpCsFixer\Finder::create(); diff --git a/.php-cs.php b/.php-cs.php deleted file mode 100644 index 095adbc..0000000 --- a/.php-cs.php +++ /dev/null @@ -1,24 +0,0 @@ - true, - 'blank_line_after_opening_tag' => false, - 'class_attributes_separation' => [ - 'elements' => ['method'] - ] -]; - -$rulesProvider = new Facile\CodingStandards\Rules\CompositeRulesProvider([ - new Facile\CodingStandards\Rules\DefaultRulesProvider(), - new Facile\CodingStandards\Rules\ArrayRulesProvider($additionalRules), -]); - -$config->setRules($rulesProvider->getRules()); - -return $config; diff --git a/composer.json b/composer.json index e14585b..7d95ef3 100644 --- a/composer.json +++ b/composer.json @@ -30,7 +30,7 @@ "symfony/console": "^3.4 || ^4.3 || ^5.0 || ^6.0", "phpunit/phpunit": "^9.6.13", "symfony/phpunit-bridge": "^7.0", - "facile-it/facile-coding-standard": "^0.4.0", + "facile-it/facile-coding-standard": "^1.0.1", "phpstan/phpstan": "1.10.50", "phpstan/extension-installer": "1.3.1", "jangregor/phpstan-prophecy": "1.0.0", @@ -66,8 +66,8 @@ } }, "scripts": { - "cs-check": "php-cs-fixer fix --dry-run --diff --config=.php-cs.php", - "cs-fix": "php-cs-fixer fix --diff --config=.php-cs.php", + "cs-check": "php-cs-fixer fix --dry-run --diff", + "cs-fix": "php-cs-fixer fix --diff", "test": "bin/phpunit tests" } } diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 1b3a819..817de83 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -20,11 +20,6 @@ parameters: count: 1 path: src/Capsule/Collection.php - - - message: "#^PHPDoc tag @var has invalid value \\(\\$profiler \\\\Symfony\\\\Component\\\\HttpKernel\\\\Profiler\\\\Profiler\\)\\: Unexpected token \"\\$profiler\", expected type at offset 9$#" - count: 1 - path: src/Controller/ProfilerController.php - - message: "#^Property Facile\\\\MongoDbBundle\\\\Controller\\\\ProfilerController\\:\\:\\$container \\(Symfony\\\\Component\\\\DependencyInjection\\\\Container\\) does not accept Symfony\\\\Component\\\\DependencyInjection\\\\ContainerInterface\\|null\\.$#" count: 1 diff --git a/src/Capsule/Client.php b/src/Capsule/Client.php index 52959b0..1e18d27 100644 --- a/src/Capsule/Client.php +++ b/src/Capsule/Client.php @@ -24,10 +24,6 @@ final class Client extends MongoClient * Client constructor. * * @param string $uri - * @param array $uriOptions - * @param array $driverOptions - * @param string $clientName - * @param EventDispatcherInterface $eventDispatcher * * @internal param DataCollectorLoggerInterface $logger */ @@ -44,7 +40,7 @@ public function __construct( } /** - * {@inheritdoc} + * @inheritDoc */ public function selectDatabase($databaseName, array $options = []) { @@ -57,7 +53,7 @@ public function selectDatabase($databaseName, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function selectCollection($databaseName, $collectionName, array $options = []) { diff --git a/src/Capsule/Collection.php b/src/Capsule/Collection.php index 49e8475..732705d 100644 --- a/src/Capsule/Collection.php +++ b/src/Capsule/Collection.php @@ -26,14 +26,6 @@ final class Collection extends MongoCollection /** @var string */ private $databaseName; - /** - * @param Manager $manager - * @param string $clientName - * @param string $databaseName - * @param string $collectionName - * @param array $options - * @param EventDispatcherInterface $eventDispatcher - */ public function __construct( Manager $manager, string $clientName, @@ -49,7 +41,7 @@ public function __construct( } /** - * {@inheritdoc} + * @inheritDoc */ public function aggregate(array $pipeline, array $options = []) { @@ -61,7 +53,7 @@ public function aggregate(array $pipeline, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function count($filter = [], array $options = []) { @@ -73,7 +65,7 @@ public function count($filter = [], array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function find($filter = [], array $options = []) { @@ -85,7 +77,7 @@ public function find($filter = [], array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function findOne($filter = [], array $options = []) { @@ -97,7 +89,7 @@ public function findOne($filter = [], array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function findOneAndUpdate($filter, $update, array $options = []) { @@ -109,7 +101,7 @@ public function findOneAndUpdate($filter, $update, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function findOneAndDelete($filter, array $options = []) { @@ -121,7 +113,7 @@ public function findOneAndDelete($filter, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function deleteMany($filter, array $options = []) { @@ -133,7 +125,7 @@ public function deleteMany($filter, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function deleteOne($filter, array $options = []) { @@ -145,7 +137,7 @@ public function deleteOne($filter, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function replaceOne($filter, $replacement, array $options = []) { @@ -157,7 +149,7 @@ public function replaceOne($filter, $replacement, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function insertOne($document, array $options = []) { @@ -169,7 +161,7 @@ public function insertOne($document, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function updateOne($filter, $update, array $options = []) { @@ -181,7 +173,7 @@ public function updateOne($filter, $update, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function distinct($fieldName, $filter = [], array $options = []) { @@ -193,12 +185,8 @@ public function distinct($fieldName, $filter = [], array $options = []) } /** - * @param string $method * @param array|object $filters * @param array|object $data - * @param array $options - * - * @return Query */ private function prepareQuery(string $method, $filters, $data, array $options): Query { @@ -224,11 +212,6 @@ private function prepareQuery(string $method, $filters, $data, array $options): return $query; } - /** - * @param ReadPreference $readPreference - * - * @return string - */ private function translateReadPreference(ReadPreference $readPreference): string { switch ($readPreference->getMode()) { @@ -247,9 +230,6 @@ private function translateReadPreference(ReadPreference $readPreference): string } } - /** - * @param Query $queryLog - */ private function notifyQueryExecution(Query $queryLog) { $queryLog->setExecutionTime(microtime(true) - $queryLog->getStart()); @@ -262,17 +242,11 @@ private function notifyQueryExecution(Query $queryLog) } } - /** - * @return string - */ public function getClientName(): string { return $this->clientName; } - /** - * @return string - */ public function getDatabaseName(): string { return $this->databaseName; diff --git a/src/Capsule/Database.php b/src/Capsule/Database.php index d43eec1..fc6a2f5 100644 --- a/src/Capsule/Database.php +++ b/src/Capsule/Database.php @@ -27,12 +27,6 @@ final class Database extends MongoDatabase /** * Database constructor. * - * @param Manager $manager - * @param string $clientName - * @param string $databaseName - * @param array $options - * @param EventDispatcherInterface $eventDispatcher - * * @internal param DataCollectorLoggerInterface $logger */ public function __construct( @@ -49,7 +43,7 @@ public function __construct( } /** - * {@inheritdoc} + * @inheritDoc */ public function selectCollection($collectionName, array $options = []) { @@ -72,7 +66,7 @@ public function selectCollection($collectionName, array $options = []) } /** - * {@inheritdoc} + * @inheritDoc */ public function withOptions(array $options = []) { diff --git a/src/Command/AbstractCommand.php b/src/Command/AbstractCommand.php index 0e5d369..9a6fba7 100644 --- a/src/Command/AbstractCommand.php +++ b/src/Command/AbstractCommand.php @@ -28,8 +28,6 @@ abstract class AbstractCommand extends Command /** * AbstractCommand constructor. - * - * @param ContainerInterface $container */ public function __construct(ContainerInterface $container, string $name = null) { @@ -43,7 +41,7 @@ protected function getContainer(): ContainerInterface } /** - * {@inheritdoc} + * @inheritDoc */ protected function configure() { @@ -53,7 +51,7 @@ protected function configure() } /** - * {@inheritdoc} + * @inheritDoc */ protected function initialize(InputInterface $input, OutputInterface $output) { diff --git a/src/Command/DropCollectionCommand.php b/src/Command/DropCollectionCommand.php index 044aaa6..22c9778 100644 --- a/src/Command/DropCollectionCommand.php +++ b/src/Command/DropCollectionCommand.php @@ -8,13 +8,10 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Output\OutputInterface; -/** - * Class DropCollectionCommand. - */ class DropCollectionCommand extends AbstractCommand { /** - * {@inheritdoc} + * @inheritDoc */ protected function configure() { @@ -26,7 +23,7 @@ protected function configure() } /** - * {@inheritdoc} + * @inheritDoc */ protected function execute(InputInterface $input, OutputInterface $output) { diff --git a/src/Command/DropDatabaseCommand.php b/src/Command/DropDatabaseCommand.php index 9b9175f..ac03742 100644 --- a/src/Command/DropDatabaseCommand.php +++ b/src/Command/DropDatabaseCommand.php @@ -7,13 +7,10 @@ use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Output\OutputInterface; -/** - * Class DropDatabaseCommand. - */ class DropDatabaseCommand extends AbstractCommand { /** - * {@inheritdoc} + * @inheritDoc */ protected function configure() { @@ -24,7 +21,7 @@ protected function configure() } /** - * {@inheritdoc} + * @inheritDoc */ protected function execute(InputInterface $input, OutputInterface $output) { diff --git a/src/Command/LoadFixturesCommand.php b/src/Command/LoadFixturesCommand.php index b961a79..3249514 100644 --- a/src/Command/LoadFixturesCommand.php +++ b/src/Command/LoadFixturesCommand.php @@ -22,7 +22,7 @@ class LoadFixturesCommand extends AbstractCommand private $loader; /** - * {@inheritdoc} + * @inheritDoc */ protected function configure() { @@ -40,7 +40,7 @@ protected function initialize(InputInterface $input, OutputInterface $output) } /** - * {@inheritdoc} + * @inheritDoc */ protected function execute(InputInterface $input, OutputInterface $output) { @@ -68,9 +68,6 @@ protected function execute(InputInterface $input, OutputInterface $output) return 0; } - /** - * @param MongoFixtureInterface $indexList - */ private function loadFixture(MongoFixtureInterface $indexList) { $indexList->loadData(); diff --git a/src/Controller/ProfilerController.php b/src/Controller/ProfilerController.php index d311d7a..7edaf32 100644 --- a/src/Controller/ProfilerController.php +++ b/src/Controller/ProfilerController.php @@ -4,12 +4,14 @@ namespace Facile\MongoDbBundle\Controller; +use Facile\MongoDbBundle\DataCollector\MongoDbDataCollector; use Facile\MongoDbBundle\DataCollector\MongoQuerySerializer; use MongoDB\BSON\UTCDateTime; use Symfony\Component\DependencyInjection\Container; use Symfony\Component\DependencyInjection\ContainerAwareInterface; use Symfony\Component\DependencyInjection\ContainerInterface; use Symfony\Component\HttpFoundation\JsonResponse; +use Symfony\Component\HttpKernel\Profiler\Profiler; class ProfilerController implements ContainerAwareInterface { @@ -27,21 +29,20 @@ public function setContainer(ContainerInterface $container = null) } /** - * @param $token - * @param $queryNumber - * * @throws \Exception * * @return JsonResponse */ public function explainAction($token, $queryNumber) { - /** @var $profiler \Symfony\Component\HttpKernel\Profiler\Profiler */ + /** @var Profiler $profiler */ $profiler = $this->container->get('profiler'); $profiler->disable(); $profile = $profiler->loadProfile($token); - $queries = $profile->getCollector('mongodb')->getQueries(); + /** @var MongoDbDataCollector $dataCollector */ + $dataCollector = $profile->getCollector('mongodb'); + $queries = $dataCollector->getQueries(); $query = $queries[$queryNumber]; diff --git a/src/DataCollector/MongoDbDataCollector.php b/src/DataCollector/MongoDbDataCollector.php index 1df88a5..8fbc2fd 100644 --- a/src/DataCollector/MongoDbDataCollector.php +++ b/src/DataCollector/MongoDbDataCollector.php @@ -17,11 +17,11 @@ */ class MongoDbDataCollector extends DataCollector { - const QUERY_KEYWORD = 'queries'; + public const QUERY_KEYWORD = 'queries'; - const CONNECTION_KEYWORD = 'connections'; + public const CONNECTION_KEYWORD = 'connections'; - const TIME_KEYWORD = 'totalTime'; + public const TIME_KEYWORD = 'totalTime'; /** @var DataCollectorLoggerInterface */ private $logger; @@ -43,9 +43,6 @@ public function reset() ]; } - /** - * @param DataCollectorLoggerInterface $logger - */ public function setLogger(DataCollectorLoggerInterface $logger) { $this->logger = $logger; @@ -70,9 +67,6 @@ public function collect(Request $request, Response $response, $exception = null) $this->data[self::CONNECTION_KEYWORD] = $this->logger->getConnections(); } - /** - * @return int - */ public function getQueryCount(): int { return \count($this->data[self::QUERY_KEYWORD]); @@ -86,17 +80,11 @@ public function getQueries(): array return $this->data[self::QUERY_KEYWORD]; } - /** - * @return float - */ public function getTime(): float { return (float) ($this->data[self::TIME_KEYWORD] * 1000); } - /** - * @return int - */ public function getConnectionsCount(): int { return \count($this->data[self::CONNECTION_KEYWORD]); @@ -111,7 +99,7 @@ public function getConnections(): array } /** - * {@inheritdoc} + * @inheritDoc */ public function getName() { diff --git a/src/DataCollector/MongoQuerySerializer.php b/src/DataCollector/MongoQuerySerializer.php index 7fb2791..a46b0d8 100644 --- a/src/DataCollector/MongoQuerySerializer.php +++ b/src/DataCollector/MongoQuerySerializer.php @@ -8,15 +8,10 @@ use MongoDB\BSON\Serializable; /** - * Class MongoQuerySerializer - * * @internal */ final class MongoQuerySerializer { - /** - * @param Query $query - */ public static function serialize(Query $query) { $query->setFilters(self::prepareUnserializableData($query->getFilters())); diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index 3ee2da1..531d87e 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -16,7 +16,7 @@ final class Configuration implements ConfigurationInterface private const READ_PREFERENCE_VALID_OPTIONS = ['primary', 'primaryPreferred', 'secondary', 'secondaryPreferred', 'nearest']; /** - * {@inheritdoc} + * @inheritDoc */ public function getConfigTreeBuilder(): TreeBuilder { diff --git a/src/Event/ConnectionEvent.php b/src/Event/ConnectionEvent.php index 79f0b38..041f28b 100644 --- a/src/Event/ConnectionEvent.php +++ b/src/Event/ConnectionEvent.php @@ -13,22 +13,16 @@ */ final class ConnectionEvent extends GenericEvent { - const CLIENT_CREATED = 'facile_mongo_db.event.connection_client.created'; + public const CLIENT_CREATED = 'facile_mongo_db.event.connection_client.created'; /** * ConnectionEvent constructor. - * - * @param string $clientName - * @param array $arguments */ public function __construct(string $clientName, array $arguments = []) { parent::__construct($clientName, $arguments); } - /** - * @return string - */ public function getClientName(): string { return $this->getSubject(); diff --git a/src/Event/Listener/DataCollectorListener.php b/src/Event/Listener/DataCollectorListener.php index aee8b50..fbae416 100644 --- a/src/Event/Listener/DataCollectorListener.php +++ b/src/Event/Listener/DataCollectorListener.php @@ -18,27 +18,16 @@ final class DataCollectorListener /** @var DataCollectorLoggerInterface */ private $logger; - /** - * DataCollectorListener constructor. - * - * @param DataCollectorLoggerInterface $logger - */ public function __construct(DataCollectorLoggerInterface $logger) { $this->logger = $logger; } - /** - * @param ConnectionEvent $event - */ public function onConnectionClientCreated(ConnectionEvent $event) { $this->logger->addConnection($event->getClientName()); } - /** - * @param QueryEvent $event - */ public function onQueryExecuted(QueryEvent $event) { $this->logger->logQuery($event->getQueryLog()); diff --git a/src/Event/QueryEvent.php b/src/Event/QueryEvent.php index 5b85386..dd159e0 100644 --- a/src/Event/QueryEvent.php +++ b/src/Event/QueryEvent.php @@ -14,24 +14,15 @@ */ final class QueryEvent extends GenericEvent { - const QUERY_PREPARED = 'facile_mongo_db.event.query_prepared'; + public const QUERY_PREPARED = 'facile_mongo_db.event.query_prepared'; - const QUERY_EXECUTED = 'facile_mongo_db.event.query_executed'; + public const QUERY_EXECUTED = 'facile_mongo_db.event.query_executed'; - /** - * QueryEvent constructor. - * - * @param Query $queryLog - * @param array $arguments - */ public function __construct(Query $queryLog, array $arguments = []) { parent::__construct($queryLog, $arguments); } - /** - * @return Query - */ public function getQueryLog(): Query { return $this->getSubject(); diff --git a/src/Fixtures/AbstractContainerAwareFixture.php b/src/Fixtures/AbstractContainerAwareFixture.php index c4ed4d0..0fd3143 100644 --- a/src/Fixtures/AbstractContainerAwareFixture.php +++ b/src/Fixtures/AbstractContainerAwareFixture.php @@ -6,25 +6,16 @@ use Symfony\Component\DependencyInjection\ContainerInterface; -/** - * Class AbstractContainerAwareFixture. - */ abstract class AbstractContainerAwareFixture { /** @var ContainerInterface */ private $container; - /** - * @return ContainerInterface - */ protected function getContainer(): ContainerInterface { return $this->container; } - /** - * @param ContainerInterface $container - */ public function setContainer(ContainerInterface $container) { $this->container = $container; diff --git a/src/Fixtures/MongoFixturesLoader.php b/src/Fixtures/MongoFixturesLoader.php index 56dca2d..86ec9f4 100644 --- a/src/Fixtures/MongoFixturesLoader.php +++ b/src/Fixtures/MongoFixturesLoader.php @@ -20,8 +20,6 @@ public function __construct(ContainerInterface $container) } /** - * @param string $dir - * * @return array */ public function loadFromDirectory(string $dir) @@ -39,8 +37,6 @@ public function loadFromDirectory(string $dir) } /** - * @param \Iterator $iterator - * * @return array */ private function loadFromIterator(\Iterator $iterator) @@ -65,8 +61,8 @@ function ($classList, string $className) use ($includedFiles) { $sourceFile = $reflClass->getFileName(); if ( - \in_array($sourceFile, $includedFiles) && - \array_key_exists(MongoFixtureInterface::class, $reflClass->getInterfaces()) + \in_array($sourceFile, $includedFiles) + && \array_key_exists(MongoFixtureInterface::class, $reflClass->getInterfaces()) ) { $instance = $this->buildFixture(new $className()); $this->addInstance($instance); @@ -81,8 +77,6 @@ function ($classList, string $className) use ($includedFiles) { /** * @param mixed $instance - * - * @return MongoFixtureInterface */ private function buildFixture($instance): MongoFixtureInterface { @@ -93,9 +87,6 @@ private function buildFixture($instance): MongoFixtureInterface return $instance; } - /** - * @param MongoFixtureInterface $list - */ public function addInstance(MongoFixtureInterface $list) { $listClass = \get_class($list); @@ -106,8 +97,6 @@ public function addInstance(MongoFixtureInterface $list) } /** - * @param string $fileName - * * @return array */ public function loadFromFile(string $fileName) diff --git a/src/Fixtures/OrderedFixtureInterface.php b/src/Fixtures/OrderedFixtureInterface.php index 44ab976..0ebefd3 100644 --- a/src/Fixtures/OrderedFixtureInterface.php +++ b/src/Fixtures/OrderedFixtureInterface.php @@ -6,7 +6,7 @@ /** * Ordered Fixture interface needs to be implemented by fixtures, - * which needs to have a specific order + * which needs to have a specific order. * * The fixtures without this interface will be loaded after those with it * diff --git a/src/Models/ClientConfiguration.php b/src/Models/ClientConfiguration.php index 8381071..d4aab17 100644 --- a/src/Models/ClientConfiguration.php +++ b/src/Models/ClientConfiguration.php @@ -29,16 +29,6 @@ final class ClientConfiguration /** @var array */ private $driverOptions; - /** - * ClientConfiguration constructor. - * - * @param string $uri - * @param string $username - * @param string $password - * @param string|null $authSource - * @param array $options - * @param array $driverOptions - */ public function __construct( string $uri, string $username = '', @@ -55,25 +45,16 @@ public function __construct( $this->driverOptions = $driverOptions; } - /** - * @return string - */ public function getUri(): string { return $this->uri; } - /** - * @return string - */ public function getUsername(): string { return $this->username; } - /** - * @return string - */ public function getPassword(): string { return $this->password; @@ -87,9 +68,6 @@ public function getAuthSource() return $this->authSource; } - /** - * @return array - */ public function getOptions(): array { return $this->cleanOptions( @@ -103,19 +81,11 @@ public function getOptions(): array ); } - /** - * @return array - */ public function getDriverOptions(): array { return $this->driverOptions; } - /** - * @param array $options - * - * @return array - */ private function cleanOptions(array $options): array { return array_filter( diff --git a/src/Models/Query.php b/src/Models/Query.php index 0f8ac57..4f4f6d8 100644 --- a/src/Models/Query.php +++ b/src/Models/Query.php @@ -58,49 +58,31 @@ public function __construct() $this->readPreference = 'undefined'; } - /** - * @return float - */ public function getStart(): float { return $this->start; } - /** - * @return string - */ public function getCollection(): string { return $this->collection; } - /** - * @param string $collection - */ public function setCollection(string $collection) { $this->collection = $collection; } - /** - * @return string - */ public function getMethod(): string { return $this->method; } - /** - * @param string $method - */ public function setMethod(string $method) { $this->method = $method; } - /** - * @return array - */ public function getFilters(): array { return $this->filters; @@ -130,25 +112,16 @@ public function setData($data): void $this->data = $data ?? []; } - /** - * @return array - */ public function getOptions(): array { return $this->options; } - /** - * @param array $options - */ public function setOptions(array $options) { $this->options = $options; } - /** - * @return float - */ public function getExecutionTime(): float { return $this->executionTime; @@ -159,49 +132,31 @@ public function setExecutionTime(float $executionTime) $this->executionTime = $executionTime; } - /** - * @return string - */ public function getReadPreference(): string { return $this->readPreference; } - /** - * @param string $readPreference - */ public function setReadPreference(string $readPreference) { $this->readPreference = $readPreference; } - /** - * @return string - */ public function getClient(): string { return $this->client; } - /** - * @param string $client - */ public function setClient(string $client) { $this->client = $client; } - /** - * @return string - */ public function getDatabase(): string { return $this->database; } - /** - * @param string $database - */ public function setDatabase(string $database) { $this->database = $database; diff --git a/src/Services/ClientRegistry.php b/src/Services/ClientRegistry.php index 8b63a9c..c9559d2 100644 --- a/src/Services/ClientRegistry.php +++ b/src/Services/ClientRegistry.php @@ -53,11 +53,6 @@ public function addClientsConfigurations(array $configurations): void } } - /** - * @param array $conf - * - * @return ClientConfiguration - */ private function buildClientConfiguration(array $conf): ClientConfiguration { if (! $conf['uri']) { @@ -131,14 +126,6 @@ public function getClient(string $name, ?string $databaseName = null): Client return $this->clients[$clientKey]; } - /** - * @param string $clientName - * @param string $uri - * @param array $options - * @param array $driverOptions - * - * @return Client - */ private function buildClient(string $clientName, string $uri, array $options, array $driverOptions): Client { if (true === $this->debug) { diff --git a/src/Services/ConnectionFactory.php b/src/Services/ConnectionFactory.php index 72d38cd..83fc160 100644 --- a/src/Services/ConnectionFactory.php +++ b/src/Services/ConnectionFactory.php @@ -16,22 +16,11 @@ final class ConnectionFactory /** @var ClientRegistry */ private $clientRegistry; - /** - * ConnectionFactory constructor. - * - * @param ClientRegistry $clientRegistry - */ public function __construct(ClientRegistry $clientRegistry) { $this->clientRegistry = $clientRegistry; } - /** - * @param string $clientName - * @param string $databaseName - * - * @return Database - */ public function createConnection(string $clientName, string $databaseName): Database { return $this->clientRegistry diff --git a/src/Services/DriverOptions/DriverOptionsInterface.php b/src/Services/DriverOptions/DriverOptionsInterface.php index e87f027..13fc0aa 100644 --- a/src/Services/DriverOptions/DriverOptionsInterface.php +++ b/src/Services/DriverOptions/DriverOptionsInterface.php @@ -9,7 +9,7 @@ interface DriverOptionsInterface { /** - * It creates an array of options for constructing a MongoDB\Client + * It creates an array of options for constructing a MongoDB\Client. * * @param array $clientConfiguration client's bundle configuration for which the options are needed * diff --git a/src/Services/Explain/ExplainCommandBuilder.php b/src/Services/Explain/ExplainCommandBuilder.php index 15c1a2d..1ecfb0b 100644 --- a/src/Services/Explain/ExplainCommandBuilder.php +++ b/src/Services/Explain/ExplainCommandBuilder.php @@ -9,12 +9,7 @@ class ExplainCommandBuilder { /** - * @param Query $query - * @param string $verbosity - * * @throws \Exception - * - * @return array */ public static function createCommandArgs( Query $query, @@ -43,12 +38,6 @@ public static function createCommandArgs( ]; } - /** - * @param Query $query - * @param $args - * - * @return array - */ private static function manageCount(Query $query, array $args): array { if ('count' === $query->getMethod()) { @@ -64,12 +53,6 @@ private static function manageCount(Query $query, array $args): array return $args; } - /** - * @param Query $query - * @param $args - * - * @return array - */ private static function manageDistinct(Query $query, array $args): array { if ('distinct' === $query->getMethod()) { @@ -82,12 +65,6 @@ private static function manageDistinct(Query $query, array $args): array return $args; } - /** - * @param Query $query - * @param array $args - * - * @return array - */ private static function manageFind(Query $query, array $args): array { if (\in_array($query->getMethod(), ['find', 'findOne', 'findOneAndUpdate', 'findOneAndDelete'])) { @@ -104,12 +81,6 @@ private static function manageFind(Query $query, array $args): array return $args; } - /** - * @param Query $query - * @param array $args - * - * @return array - */ private static function manageDelete(Query $query, array $args): array { if (\in_array($query->getMethod(), ['deleteOne', 'deleteMany'])) { diff --git a/src/Services/Explain/ExplainQueryService.php b/src/Services/Explain/ExplainQueryService.php index b0f54a2..b3ef09e 100644 --- a/src/Services/Explain/ExplainQueryService.php +++ b/src/Services/Explain/ExplainQueryService.php @@ -9,11 +9,11 @@ class ExplainQueryService { - const VERBOSITY_QUERY_PLANNER = 'queryPlanner'; + public const VERBOSITY_QUERY_PLANNER = 'queryPlanner'; - const VERBOSITY_EXECUTION_STATS = 'executionStats'; + public const VERBOSITY_EXECUTION_STATS = 'executionStats'; - const VERBOSITY_ALL_PLAN_EXECUTION = 'allPlansExecution'; + public const VERBOSITY_ALL_PLAN_EXECUTION = 'allPlansExecution'; public const ACCEPTED_METHODS = [ 'count', @@ -37,8 +37,6 @@ class ExplainQueryService * verbosity : queryPlanner | executionStats Mode | allPlansExecution (default) * The explain command provides information on the execution of the following commands: * count, distinct, group, find, findAndModify, delete, and update. - * - * @param ClientRegistry $clientRegistry */ public function __construct(ClientRegistry $clientRegistry) { @@ -48,12 +46,7 @@ public function __construct(ClientRegistry $clientRegistry) /** * Execute the operation. * - * @param Query $query - * @param string $verbosity - * * @throws \Exception - * - * @return Cursor */ public function execute(Query $query, string $verbosity = self::VERBOSITY_ALL_PLAN_EXECUTION): Cursor { diff --git a/src/Services/Loggers/DataCollectorLoggerInterface.php b/src/Services/Loggers/DataCollectorLoggerInterface.php index 9557e3b..06cace7 100644 --- a/src/Services/Loggers/DataCollectorLoggerInterface.php +++ b/src/Services/Loggers/DataCollectorLoggerInterface.php @@ -6,29 +6,14 @@ use Facile\MongoDbBundle\Models\Query; -/** - * Interface DataCollectorLoggerInterface - */ interface DataCollectorLoggerInterface { - /** - * @param Query $event - */ public function logQuery(Query $event); - /** - * @return bool - */ public function hasLoggedEvents(): bool; - /** - * @return Query - */ public function getLoggedEvent(): Query; - /** - * @param string $connection - */ public function addConnection(string $connection); /** diff --git a/src/Services/Loggers/MongoQueryLogger.php b/src/Services/Loggers/MongoQueryLogger.php index c11169b..e17e225 100644 --- a/src/Services/Loggers/MongoQueryLogger.php +++ b/src/Services/Loggers/MongoQueryLogger.php @@ -23,9 +23,6 @@ public function __construct() $this->connections = []; } - /** - * @param string $connection - */ public function addConnection(string $connection) { $this->connections[] = $connection; @@ -39,17 +36,11 @@ public function getConnections(): array return $this->connections; } - /** - * @param Query $event - */ public function logQuery(Query $event) { $this->logs->enqueue($event); } - /** - * @return Query - */ public function getLoggedEvent(): Query { if (! $this->hasLoggedEvents()) { @@ -59,9 +50,6 @@ public function getLoggedEvent(): Query return $this->logs->dequeue(); } - /** - * @return bool - */ public function hasLoggedEvents(): bool { return ! $this->logs->isEmpty(); diff --git a/tests/Fixtures/DataFixtures/TestFixtures.php b/tests/Fixtures/DataFixtures/TestFixtures.php index 09f95c6..872b378 100644 --- a/tests/Fixtures/DataFixtures/TestFixtures.php +++ b/tests/Fixtures/DataFixtures/TestFixtures.php @@ -29,13 +29,8 @@ public function loadData() /** * @return array */ - public function loadIndexes() - { - } + public function loadIndexes() {} - /** - * @return string - */ public function collection(): string { return 'testFixturesCollection'; diff --git a/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures.php b/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures.php index e5bc7ab..f8f04db 100644 --- a/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures.php +++ b/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures.php @@ -30,9 +30,7 @@ public function getOrder(): int return 1; } - public function loadIndexes() - { - } + public function loadIndexes() {} public function collection(): string { diff --git a/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures1.php b/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures1.php index 92640e2..85633e2 100644 --- a/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures1.php +++ b/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures1.php @@ -30,9 +30,7 @@ public function getOrder(): int return 200; } - public function loadIndexes() - { - } + public function loadIndexes() {} public function collection(): string { diff --git a/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures2.php b/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures2.php index 098d089..91194e9 100644 --- a/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures2.php +++ b/tests/Fixtures/DataFixtures/TestOrderedMongoFixtures2.php @@ -30,13 +30,8 @@ public function loadData() /** * @return array */ - public function loadIndexes() - { - } + public function loadIndexes() {} - /** - * @return string - */ public function collection(): string { return 'testFixturesOrderedCollection'; diff --git a/tests/Functional/AppTestCase.php b/tests/Functional/AppTestCase.php index 0baee11..e46f52f 100644 --- a/tests/Functional/AppTestCase.php +++ b/tests/Functional/AppTestCase.php @@ -9,9 +9,6 @@ use Symfony\Bundle\FrameworkBundle\Console\Application; use Symfony\Component\DependencyInjection\ContainerInterface; -/** - * Class AppTestCase. - */ class AppTestCase extends TestCase { /** @var Application */ @@ -34,17 +31,11 @@ protected function tearDown(): void $this->application = null; } - /** - * @return Application - */ protected function getApplication(): Application { return $this->application; } - /** - * @return ContainerInterface - */ protected function getContainer(): ContainerInterface { return $this->application->getKernel()->getContainer(); diff --git a/tests/Functional/Capsule/CollectionTest.php b/tests/Functional/Capsule/CollectionTest.php index 0211e8b..1785f2c 100644 --- a/tests/Functional/Capsule/CollectionTest.php +++ b/tests/Functional/Capsule/CollectionTest.php @@ -188,9 +188,6 @@ public function test_distinct() $coll->distinct('field'); } - /** - * @param $ev - */ protected function assertEventsDispatching($ev) { if (Kernel::VERSION_ID >= 40300) { diff --git a/tests/Functional/DependencyInjection/MongoDbBundleExtensionTest.php b/tests/Functional/DependencyInjection/MongoDbBundleExtensionTest.php index f060499..6c27612 100644 --- a/tests/Functional/DependencyInjection/MongoDbBundleExtensionTest.php +++ b/tests/Functional/DependencyInjection/MongoDbBundleExtensionTest.php @@ -20,9 +20,9 @@ class MongoDbBundleExtensionTest extends AbstractExtensionTestCase { - const LOGGER_PUBLIC_ALIAS = 'facile_mongo_db.logger.public'; + public const LOGGER_PUBLIC_ALIAS = 'facile_mongo_db.logger.public'; - const DISPATCHER_PUBLIC_ALIAS = 'facile_mongo_db.event_dispatcher.public'; + public const DISPATCHER_PUBLIC_ALIAS = 'facile_mongo_db.event_dispatcher.public'; protected function setUp(): void { diff --git a/tests/Functional/TestApp/TestKernel.php b/tests/Functional/TestApp/TestKernel.php index 61efd63..0d1540c 100644 --- a/tests/Functional/TestApp/TestKernel.php +++ b/tests/Functional/TestApp/TestKernel.php @@ -13,7 +13,7 @@ class TestKernel extends Kernel { /** - * {@inheritdoc} + * @inheritDoc * * @return Bundle[] */ @@ -26,7 +26,7 @@ public function registerBundles(): array } /** - * {@inheritdoc} + * @inheritDoc */ public function registerContainerConfiguration(LoaderInterface $loader) { diff --git a/tests/Unit/DataCollector/MongoQuerySerializerTest.php b/tests/Unit/DataCollector/MongoQuerySerializerTest.php index fad285d..92705a4 100644 --- a/tests/Unit/DataCollector/MongoQuerySerializerTest.php +++ b/tests/Unit/DataCollector/MongoQuerySerializerTest.php @@ -15,8 +15,6 @@ class MongoQuerySerializerTest extends TestCase use \Prophecy\PhpUnit\ProphecyTrait; /** - * @param $unserializedData - * * @dataProvider unserializedDataProvider */ public function test_serializer($unserializedData, $expectedSerialization) diff --git a/tests/Unit/Fixtures/FixtureSorterTest.php b/tests/Unit/Fixtures/FixtureSorterTest.php index 961f691..469f75c 100644 --- a/tests/Unit/Fixtures/FixtureSorterTest.php +++ b/tests/Unit/Fixtures/FixtureSorterTest.php @@ -52,7 +52,7 @@ private function assertIsAfter(string $collectionsSorted, string $collection, ar private function mockUnordered(string $collectionName): MongoFixtureInterface { - return new class($collectionName) implements MongoFixtureInterface { + return new class ($collectionName) implements MongoFixtureInterface { /** @var string */ private $collectionName; @@ -61,13 +61,9 @@ public function __construct(string $collectionName) $this->collectionName = $collectionName; } - public function loadData() - { - } + public function loadData() {} - public function loadIndexes() - { - } + public function loadIndexes() {} public function collection(): string { @@ -78,7 +74,7 @@ public function collection(): string private function mockOrdered(int $order, string $collectionName): OrderedFixtureInterface { - return new class($order, $collectionName) implements MongoFixtureInterface, OrderedFixtureInterface { + return new class ($order, $collectionName) implements MongoFixtureInterface, OrderedFixtureInterface { /** @var int */ private $order; @@ -91,13 +87,9 @@ public function __construct(int $order, string $collectionName) $this->collectionName = $collectionName; } - public function loadData() - { - } + public function loadData() {} - public function loadIndexes() - { - } + public function loadIndexes() {} public function collection(): string { diff --git a/tests/Unit/Models/ClientConfigurationTest.php b/tests/Unit/Models/ClientConfigurationTest.php index 1213814..b43a0cf 100644 --- a/tests/Unit/Models/ClientConfigurationTest.php +++ b/tests/Unit/Models/ClientConfigurationTest.php @@ -50,9 +50,6 @@ public function test_construction_empty_credentials() } /** - * @param array $options - * @param array $expectedOptions - * * @dataProvider optionsDataProvider */ public function test_construction_with_options(array $options, array $expectedOptions) diff --git a/tests/Unit/Services/Explain/ExplainCommandBuilderTest.php b/tests/Unit/Services/Explain/ExplainCommandBuilderTest.php index 3c00d0d..772eba6 100644 --- a/tests/Unit/Services/Explain/ExplainCommandBuilderTest.php +++ b/tests/Unit/Services/Explain/ExplainCommandBuilderTest.php @@ -76,9 +76,6 @@ public function test_aggregate() /** * @dataProvider findsProvider - * - * @param string $method - * @param bool $projection */ public function test_finds(string $method, bool $projection = false) { @@ -121,9 +118,6 @@ public function findsProvider() /** * @dataProvider deletedsProvider - * - * @param string $method - * @param int $limit */ public function test_deletes(string $method, int $limit = 0) { diff --git a/tests/Unit/Twig/FacileMongoDbBundleExtensionTest.php b/tests/Unit/Twig/FacileMongoDbBundleExtensionTest.php index bf24d51..bf9b40f 100644 --- a/tests/Unit/Twig/FacileMongoDbBundleExtensionTest.php +++ b/tests/Unit/Twig/FacileMongoDbBundleExtensionTest.php @@ -10,10 +10,6 @@ class FacileMongoDbBundleExtensionTest extends TestCase { /** - * @param string $label - * @param string $methodname - * @param string $expected - * * @dataProvider labelMethodProvider */ public function test_queryDataTranslate(string $label, string $methodname, string $expected) @@ -24,9 +20,6 @@ public function test_queryDataTranslate(string $label, string $methodname, strin /** * @dataProvider explainMethodsProvider - * - * @param string $methodname - * @param bool $expected */ public function test_isQueryExplainable(string $methodname, bool $expected) {