Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit for expected tibble outputs in unit tests #16

Open
6 tasks
lianos opened this issue Jun 1, 2020 · 0 comments
Open
6 tasks

Be more explicit for expected tibble outputs in unit tests #16

lianos opened this issue Jun 1, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lianos
Copy link
Member

lianos commented Jun 1, 2020

After dplyr 1.0 dropped, it became clear where the expect_equal() calls were implicitly ignore attribute checking: we create tibbles of expected output to test against, but the class attributes of the data returned from the facile api isn't just a plain tibble.

For now, these unit tests set expect_equal(returned, expected, **check.attributes = FALSE**) in order to ignore class matching. This is good enough for now since we are most interested in ensuring that the data we get back is sound.

It would be good to more explicitly test the class attributes of the data returned to help formalize what types of classes are returned from which API calls.

These are the unit test locations where check.attributes = FALSE needed to be added.

@lianos lianos added the enhancement New feature or request label Jun 1, 2020
@lianos lianos self-assigned this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant